Invert feture flag to enable enforcing @alias by default

Reviewed By: gordyf Differential Revision: D69669990 fbshipit-source-id: 266a35bed4f4798ebadc3d725682fd81f6341a11
facebook · Feb 20, 2025 · c98f82a · c98f82a
1 parent 9d556e7
commit c98f82a
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/compiler/crates/common/src/feature_flags.rs b/compiler/crates/common/src/feature_flags.rs
@@ -50,7 +50,7 @@ pub struct FeatureFlags {
 
     /// Enforce that you must add `@alias` to a fragment if it may not match,
     /// due to type mismatch or `@skip`/`@include`
-    #[serde(default)]
+    #[serde(default = "enabled_feature_flag")]
     pub enforce_fragment_alias_where_ambiguous: FeatureFlag,
 
     /// Print queries in compact form
@@ -189,6 +189,11 @@ pub enum FeatureFlag {
     RolloutRange { rollout: RolloutRange },
 }
 
+/// Used for making feature flags enabled by default via Serde's default attribute.
+fn enabled_feature_flag() -> FeatureFlag {
+    FeatureFlag::Enabled
+}
+
 impl FeatureFlag {
     pub fn is_enabled_for(&self, name: StringKey) -> bool {
         match self {

diff --git a/compiler/crates/relay-compiler/relay-compiler-config-schema.json b/compiler/crates/relay-compiler/relay-compiler-config-schema.json
@@ -1128,7 +1128,7 @@
             "enforce_fragment_alias_where_ambiguous": {
               "description": "Enforce that you must add `@alias` to a fragment if it may not match, due to type mismatch or `@skip`/`@include`",
               "default": {
-                "kind": "disabled"
+                "kind": "enabled"
               },
               "oneOf": [
                 {
@@ -3708,7 +3708,7 @@
             "enforce_fragment_alias_where_ambiguous": {
               "description": "Enforce that you must add `@alias` to a fragment if it may not match, due to type mismatch or `@skip`/`@include`",
               "default": {
-                "kind": "disabled"
+                "kind": "enabled"
               },
               "oneOf": [
                 {
@@ -5925,7 +5925,7 @@
                   "enforce_fragment_alias_where_ambiguous": {
                     "description": "Enforce that you must add `@alias` to a fragment if it may not match, due to type mismatch or `@skip`/`@include`",
                     "default": {
-                      "kind": "disabled"
+                      "kind": "enabled"
                     },
                     "oneOf": [
                       {

diff --git a/..._compiler_integration/fixtures/repro_dangerously_unaliased_changes_output_before.expected b/..._compiler_integration/fixtures/repro_dangerously_unaliased_changes_output_before.expected
@@ -36,6 +36,9 @@ query ModuleNameQuery {
    "featureFlags": {
       "disable_deduping_common_structures_in_artifacts": {
          "kind": "enabled"
+      },
+      "enforce_fragment_alias_where_ambiguous": {
+         "kind": "disabled"
       }
    }
 }

diff --git a/...lay_compiler_integration/fixtures/repro_dangerously_unaliased_changes_output_before.input b/...lay_compiler_integration/fixtures/repro_dangerously_unaliased_changes_output_before.input
@@ -35,6 +35,9 @@ query ModuleNameQuery {
    "featureFlags": {
       "disable_deduping_common_structures_in_artifacts": {
          "kind": "enabled"
+      },
+      "enforce_fragment_alias_where_ambiguous": {
+         "kind": "disabled"
       }
    }
 }

diff --git a/scripts/config.tests.json b/scripts/config.tests.json
@@ -62,7 +62,10 @@
         "relay_resolver_enable_interface_output_type": {
           "kind": "enabled"
         },
-        "enable_exec_time_resolvers_directive": true
+        "enable_exec_time_resolvers_directive": true,
+        "enforce_fragment_alias_where_ambiguous": {
+          "kind": "disabled"
+        }
       },
       "language": "flow",
       "resolverContextType": {