Skip to content

make single pr workflow default for sl pr submit #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

make single pr workflow default for sl pr submit #1067

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6a9d17
make `single` pr workflow default for `sl pr submit`
discentem Apr 26, 2025
c91ca70
Merge branch 'main' into patch-4
discentem Apr 27, 2025
3df8091
Update code comment to be accurate for default strategy
discentem May 27, 2025
8f17819
Merge branch 'main' into patch-4
discentem May 27, 2025
38ce4eb
Merge branch 'main' into patch-4
discentem Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eden/scm/sapling/ext/github/submit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ def from_config(ui) -> "SubmitWorkflow":
workflow = ui.config(
"github", "pr-workflow", ui.config("github", "pr_workflow")
)
if not workflow or workflow == "overlap":
# For now, default to OVERLAP.
return SubmitWorkflow.OVERLAP
elif workflow == "single":
if not workflow or workflow == "single":
# For now, default to SINGLE.
return SubmitWorkflow.SINGLE
elif workflow == "overlap":
return SubmitWorkflow.OVERLAP
else:
# Note that "classic" is not recognized yet.
ui.warn(
Expand Down