Add support for build script [env_flags]
sub-target
#74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows Reindeer to generate rules that utilize environment variable outputs from build scripts.
Relates to facebook/buck2#929.
Changes
[env_flags]
sub-target onbuildscript_run
For example, for the problematic
mime_guess
crate, Reindeer can now generate:This eliminates the need for manual environment variable fixups for crates that use
cargo:rustc-env
.Testing
A demonstration repository verifies this works for
mime_guess
andring
crates, both havecargo:rustc-env
outputs from build scripts.