WithoutAuth instead CallWithoutAuth, GetSystemDateAndTime can required auth on some cameras

parse posix timezone can stop on H:m
defer resp.Body.Close for try fix memory leak

Author: atagirov

deviceService.go

@@ -17,6 +17,12 @@ func NewDeviceService(onvifDevice *OnvifDevice) *DeviceService {
 	}
 }
 
+func (s *DeviceService) WithoutAuth() *DeviceService {
+	return &DeviceService{
+		Client: s.Client.WithoutAuth(),
+	}
+}
+
 // GetDeviceInformation gets basic device information from the device.
 func (s *DeviceService) GetDeviceInformation() (res tds.GetDeviceInformationResponse, err error) {
 	err = s.Client.Call(tds.GetDeviceInformation{}, &res)
@@ -38,7 +44,7 @@ func (s *DeviceService) GetServices(includeCapability bool) (res tds.GetServices
 //
 // A device shall provide the UTCDateTime information.
 func (s *DeviceService) GetSystemDateAndTime() (res tds.GetSystemDateAndTimeResponse, err error) {
-	err = s.Client.CallWithoutAuth(tds.GetSystemDateAndTime{}, &res)
+	err = s.Client.Call(tds.GetSystemDateAndTime{}, &res)
 	return
 }
 

mediaService.go

@@ -15,6 +15,12 @@ func NewMediaService(endpoint string, onvifAuth *onvifAuth) *MediaService {
 	}
 }
 
+func (s *MediaService) WithoutAuth() *MediaService {
+	return &MediaService{
+		Client: s.Client.WithoutAuth(),
+	}
+}
+
 // GetProfiles using for ask the existing media profiles of a device
 // Pre-configured or dynamically configured profiles can be retrieved using this command.
 // This command lists all configured profiles in a device.

onvif/posix_timezone.go

@@ -223,6 +223,12 @@ func parsePosixTimezoneTime(t *posixTimezoneTime, timePart string) error {
 	switch state {
 	case weekend:
 		t.Weekday, err = strconv.Atoi(timePart[start:])
+	case hours:
+		t.Hours, err = strconv.Atoi(timePart[start:])
+		t.Minutes, t.Seconds = 0, 0
+	case minutes:
+		t.Minutes, err = strconv.Atoi(timePart[start:])
+		t.Seconds = 0
 	case seconds:
 		t.Seconds, err = strconv.Atoi(timePart[start:])
 	}

onvifClient.go

@@ -9,7 +9,7 @@ import (
 type onvifCaller interface {
 	Call(request, response interface{}) error
 
-	CallWithoutAuth(request, response interface{}) error
+	WithoutAuth() onvifCaller
 }
 
 type onvifAuth struct {
@@ -30,19 +30,18 @@ func NewOnvifClient(endpoint string, auth *onvifAuth) *onvifClient {
 	}
 }
 
-func (c *onvifClient) callOnInternal(request, response interface{}, useAuth bool) error {
-	if c.auth.login != "" && useAuth {
+func (c *onvifClient) Call(request, response interface{}) error {
+	if c.auth.login != "" {
 		return c.soapClient.Do(request, response,
 			soap.MakeWSSecurity(c.auth.login, c.auth.password, c.auth.timeDiff))
 	}
 
 	return c.soapClient.Do(request, response)
 }
 
-func (c *onvifClient) Call(request, response interface{}) error {
-	return c.callOnInternal(request, response, true)
-}
-
-func (c *onvifClient) CallWithoutAuth(request, response interface{}) error {
-	return c.callOnInternal(request, response, false)
+func (c *onvifClient) WithoutAuth() onvifCaller {
+	return &onvifClient{
+		soapClient: c.soapClient,
+		auth:       &onvifAuth{},
+	}
 }

onvifdevice.go

@@ -62,7 +62,7 @@ func (onvifDevice *OnvifDevice) Initialize() error {
 	deviceService := NewDeviceService(onvifDevice)
 
 	currentTime := time.Now().UTC()
-	systemDateAndTimeResponse, err := deviceService.GetSystemDateAndTime()
+	systemDateAndTimeResponse, err := deviceService.WithoutAuth().GetSystemDateAndTime()
 	if err == nil {
 		//TODO: warn if GetSystemDateAndTime return err
 		deviceTime, _ := systemDateAndTimeResponse.SystemDateAndTime.GetUTCTime()

soap/client.go

@@ -43,6 +43,8 @@ func (soap *SoapClient) Do(request, response interface{}, headers ...interface{}
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
+
 	if resp.StatusCode != http.StatusOK &&
 		resp.StatusCode != http.StatusInternalServerError &&
 		resp.StatusCode != http.StatusBadRequest {