Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Rules only allow you to select from first ten users #1332

Open
1 task done
RankWeis opened this issue Feb 5, 2025 · 1 comment · May be fixed by #1333
Open
1 task done

Override Rules only allow you to select from first ten users #1332

RankWeis opened this issue Feb 5, 2025 · 1 comment · May be fixed by #1333
Labels
bug Something isn't working confirmed This bug has been reproduced

Comments

@RankWeis
Copy link

RankWeis commented Feb 5, 2025

Description

Even if I make a new rule with just user 11, although it appears in the 'main' page with their name, it does not add them to the actual rules. It's hard for me to give images without giving away some of my users PII. If unable to reproduce, I can share in a private channel.

Feature request on top - The use case for this specifically is that I want to add all 15 of my jellyseerr users to a rule (except for me) - a nicer option would be to select all or invert selection.

Version

2.3.0

Steps to Reproduce

  1. Have 11+ users
  2. Go to Services, choose any service
  3. Attempt to add a rule
  4. Notice that only the first ten users appear on this list. You can search for the users beyond this, and they will appear on the screen until you hit save. But if you go back to that rule, they are not there.

Expected behavior: I should be able to at the very least search and add these users, but would prefer to see them all in a list

Screenshots

This shows that user 11 does appear on the 'main' page -
Image

But back in the rule they still do not -

Image

Logs

Platform

desktop

Database

SQLite (default)

Device

All, but this was an macbook pro

Operating System

All, but this was macOS. The server was running in a k3s cluster in Ubuntu 22.04

Browser

All, but this was Safari. Have tested on firefox as well.

Additional Context

I am unable to get debug logs working but I will update if I can.

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@RankWeis RankWeis added awaiting triage This issue needs to be reviewed bug Something isn't working labels Feb 5, 2025
@RankWeis
Copy link
Author

RankWeis commented Feb 5, 2025

Not familiar with this codebase but just searching around it seems like this function doesn't accept a limit for the users - https://github.com/fallenbagel/jellyseerr/blob/develop/src/components/Selector/index.tsx#L552

But that's probably fine if you only want to select 10 users at a time for performance reasons, however later on it filters out users if they don't exist in that initial response - https://github.com/fallenbagel/jellyseerr/blob/develop/src/components/Selector/index.tsx#L576

Probably there it needs to check that if the user isn't in the first ten, do they exist in the db at all, and only then filter them out

@gauthier-th gauthier-th added confirmed This bug has been reproduced and removed awaiting triage This issue needs to be reviewed labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This bug has been reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants