High number of DNS queries

[ishanjain28]

Description

I don't fully understand the code base so please excuse me if this is just wrong.

As far as I understand, It is using fetch every where, setting up and tearing down connections when it's done. It is not using a shared http client and it is not using connection pools.

The problem with the current approach, Jellyseerr generates ridiculously high amount of DNS traffic. In the last 2 weeks, I now have 84k requests to themoviedb.

Version

2.3

Steps to Reproduce

1. Install Jellyseer
2. Use it for a while
3. Take a look at the amount of DNS traffic generated by it

Screenshots

No response

Logs

DNS Traffic over the last 2 weeks 

      4 10.0.50.24 _http._tcp.security.debian.org
      4 10.0.50.24 _https._tcp.deb.nodesource.com
      4 10.0.50.24 objects.githubusercontent.com
      6 10.0.50.24 fcm.googleapis.com
      6 10.0.50.24 fonts.googleapis.com
     12 10.0.50.24 _http._tcp.deb.debian.org
     12 10.0.50.24 deb.nodesource.com
     14 10.0.50.24 github.com
     22 10.0.50.24 updates.push.services.mozilla.com
     32 10.0.50.24 debian.map.fastlydns.net
     32 10.0.50.24 telemetry.nextjs.org
     50 10.0.50.24 registry.npmjs.org
    154 10.0.50.24 api.pushover.net
    168 10.0.50.24 api.radarr.video
    234 10.0.50.24 79frdp12pn-dsn.algolia.net
   1091 10.0.50.24 gravatar.com
   4490 10.0.50.24 image.tmdb.org
  84173 10.0.50.24 api.themoviedb.org

Platform

desktop

Database

PostgreSQL

Device

Android, iPad Pro

Operating System

iPadOS 18, Android 15

Browser

Firefox, Safari

Additional Context

I believe, reusing connections and sharing the http client across all the places it is used should reduce the DNS traffic.

Code of Conduct

• I agree to follow Jellyseerr's Code of Conduct

[gauthier-th]

Duplicate of #728
This is something related to the way Node.js works. #1294 may solve that.

[gauthier-th]

It is not using a shared http client and it is not using connection pools.

What do you mean a shared http agent? It's using the default Agent from Node.js, which has keepAlive enabled with a timeout of 5s.

Edit: my bad, we don't use the default Agent of Node.js anymore (because of this) since a custom agent was added for HTTP proxy. I'll make a PR to set back the default value of keepAlive.

[ishanjain28]

It's using the default Agent from Node.js, which has keepAlive enabled with a timeout of 5s.

This is what I meant. Usually people create a customized http client and use that every where. I guess it's okay to use the global agent as well.

Thanks for looking into this and responding to it! I'll close it since it's duplicate

[ishanjain28]

Edit: my bad, we don't use the default Agent of Node.js anymore (because of this) since a custom agent was added for HTTP proxy. I'll make a PR to set back the default value of keepAlive.

Thank you! Closing this for aforementioned reason