Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default forgot password does not work and input validation prevents one for emby from being added #1406

Open
1 task done
liamlows opened this issue Feb 27, 2025 · 1 comment
Labels
awaiting triage This issue needs to be reviewed bug Something isn't working

Comments

@liamlows
Copy link

liamlows commented Feb 27, 2025

Description

So there are two issues noted below.

First, the default password reset functionality for an Emby setup (have not tested others) does not work. When clicking the "reset password" button, the page just refreshes and tacks on #!/startup/forgotpassword.html to the end of the Jellyseerr URL.

I believe the error resides where the baseURL is being fetched since its trying to access what seems to be a nonexistent attribute jellyfinExternalHost from the settings hook. I checked this against the settings API route and I do not see that attribute being returned nor is it listed in the default settings object.

Second, when trying to correct this by providing the proper password reset URL in the media server settings (input field "Forgot Password URL"), validation fails saying the hashbang or specifically the ! part of the hashbang is invalid. An example would be [EMBY_HOST]/web/index.html#!/startup/forgotpassword.html. The validation occurs here.

I am happy to provide a fix for this adding the necessary attribute to the settings request response pulling it from config/settings and to also updating the input validation to support hashbangs, but I figured making an issue for it first to check that is the intended functionality would be best.

Version

2.3.0

Steps to Reproduce

Issue 1:

  1. Setup Jellyseerr with emby media server connection
  2. After setup, logout and attempt to click "Forgot Password?"
  3. Verify URL change and that navigation to Emby server did not occur

Issue 2:

  1. Attempt to paste in the default Emby password reset URL in the "Forgot Password URL" input field in the settings [EMBY_HOST]/web/index.html#!/startup/forgotpassword.html
  2. Verify input validation fails on the hashbang portion of the URL

Screenshots

No response

Logs

N/A

Platform

desktop

Database

SQLite (default)

Device

iPhone, PC, Macbook, any device

Operating System

Windows 11 Pro

Browser

Firefox and Chrome

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@liamlows liamlows added awaiting triage This issue needs to be reviewed bug Something isn't working labels Feb 27, 2025
@gauthier-th
Copy link
Collaborator

This should be fixed in develop. Can you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage This issue needs to be reviewed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants