Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): prevent password manager interference & improve service links #1396

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

s0up4200
Copy link
Contributor

(cherry picked from commit ef18b5d1de0bf2fe13975c3f488d90299fc717fe)

Description

This PR prevents unwanted password manager autofill in configuration forms and improves service link behavior.

Key Changes

  • Added password manager prevention attributes:
    • 1Password (data-1pignore)
    • LastPass (data-lpignore)
    • Bitwarden (data-bwignore)
  • Centralized prevention attributes in SensitiveInput component
  • Preserved Local Login form password manager functionality
  • Modified service links to open in new tabs
  • Removed redundant autoComplete="one-time-code" attributes

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

Issues Fixed or Closed

  • None

…ks (#3989)

(cherry picked from commit ef18b5d1de0bf2fe13975c3f488d90299fc717fe)
@gauthier-th
Copy link
Collaborator

This is included in #1404.
But I can see that there is missing changes for Jellyfin-related components, in:

  • src/components/Login/JellyfinLogin.tsx
  • src/components/Settings/SettingsJellyfin.tsx

Once #1404 is merged, can you please rebase on develop and add these changes to your PR? 🙏

@s0up4200
Copy link
Contributor Author

Ah of course you merge upstream, I should've known 😄

I did have a brief look yesterday and looks like Jellyfin is using the SensitiveInput componentent already, but I'll double check 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants