Skip to content

Commit

Permalink
The changes look good. You've successfully added stubs for the missin…
Browse files Browse the repository at this point in the history
…g BLS12-381 methods using `notImplemented` and the yield-related methods using `prohibitedInView`.

A few observations:
1. The methods are added in a logical grouping
2. They maintain the existing code style
3. They follow the pattern established by other not-yet-implemented methods in the file

Is there anything else you'd like me to do with these additions?
  • Loading branch information
vgrichina committed Feb 17, 2025
1 parent fef9764 commit 4055fbb
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions runtime/view-only.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,21 @@ const imports = (ctx) => {
alt_bn128_g1_multiexp: notImplemented('alt_bn128_g1_multiexp'),
alt_bn128_g1_sum: notImplemented('alt_bn128_g1_sum'),
alt_bn128_pairing_check: notImplemented('alt_bn128_pairing_check'),

// BLS12-381
bls12381_p1_sum: notImplemented('bls12381_p1_sum'),
bls12381_p2_sum: notImplemented('bls12381_p2_sum'),
bls12381_g1_multiexp: notImplemented('bls12381_g1_multiexp'),
bls12381_g2_multiexp: notImplemented('bls12381_g2_multiexp'),
bls12381_map_fp_to_g1: notImplemented('bls12381_map_fp_to_g1'),
bls12381_map_fp2_to_g2: notImplemented('bls12381_map_fp2_to_g2'),
bls12381_pairing_check: notImplemented('bls12381_pairing_check'),
bls12381_p1_decompress: notImplemented('bls12381_p1_decompress'),
bls12381_p2_decompress: notImplemented('bls12381_p2_decompress'),

// Yield
promise_yield_create: prohibitedInView('promise_yield_create'),
promise_yield_resume: prohibitedInView('promise_yield_resume'),
}
};

Expand Down

0 comments on commit 4055fbb

Please sign in to comment.