Skip to content

Commit c244360

Browse files
authored
Merge pull request #155 from fastruby/STJ-20-old-ruby-support
Bring back support of Ruby 2.3, 2.4 and 2.5
2 parents 3d35c23 + 2c367d5 commit c244360

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
ruby-version: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7", "2.6", "2.5"]
16+
ruby-version: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7", "2.6", "2.5", "2.4", "2.3"]
1717

1818
steps:
1919
- uses: actions/checkout@v2

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
- [BUGFIX: example](https://github.com/fastruby/next_rails/pull/<number>)
44
- [CHORE: Create an entry point for the BundleReport command](https://github.com/fastruby/next_rails/pull/154)
5+
- [CHORE: Bring back support of Ruby 2.3, 2.4 and 2.5](https://github.com/fastruby/next_rails/pull/155)
56

67
* Your changes/patches go here.
78

lib/next_rails/bundle_report/cli.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
require "optparse"
44
require "next_rails"
55
require "next_rails/bundle_report"
6+
require "byebug"
67

78
class NextRails::BundleReport::CLI
89
def initialize(argv)
@@ -21,11 +22,11 @@ def validate_arguments(argv)
2122
end
2223

2324
argv.each do |arg|
24-
if arg.start_with?("--rails-version") && !arg.match?(/--rails-version=+\d+(\.\d+)*$/)
25+
if arg.start_with?("--rails-version") && !/--rails-version=+\d+(\.\d+)*$/.match(arg)
2526
raise ArgumentError, "Invalid Rails version format. Example: --rails-version=5.0.7"
2627
end
2728

28-
if arg.start_with?("--ruby-version") && !arg.match?(/--ruby-version=+\d+(\.\d+)*$/)
29+
if arg.start_with?("--ruby-version") && !/--ruby-version=+\d+(\.\d+)*$/.match(arg)
2930
raise ArgumentError, "Invalid Ruby version format. Example: --ruby-version=3.3"
3031
end
3132
end

next_rails.gemspec

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ Gem::Specification.new do |spec|
2929
spec.add_development_dependency "simplecov", "~> 0.17.1"
3030
spec.add_development_dependency "timecop", "~> 0.9.1"
3131
spec.add_development_dependency "byebug"
32-
spec.add_development_dependency "rexml", "3.3.8" # limited on purpose, new versions don't work with old rubies
33-
spec.add_development_dependency "webmock", "3.20.0"
32+
spec.add_development_dependency "rexml", "3.2.5" # limited on purpose, new versions don't work with old rubies
33+
spec.add_development_dependency "webmock", "3.16.2"
34+
spec.add_development_dependency "base64"
3435
end

0 commit comments

Comments
 (0)