Skip to content

[BUG] NextRails deprecation_tracker breaking with unknown keywords: #152

Open
@prostko

Description

@prostko

Expected Behavior

NextRails deprecation tracker should support keywords, or at the very least should not throw errors when encountering unknown keywords.

Actual Behavior

NextRails blows up installation by throwing an error.

rake aborted!
ActionView::Template::Error: unknown keywords: :deprecation, :span, :stack
/home/runner/work/app_name/app_name/vendor/bundle/ruby/2.7.0/gems/next_rails-1.3.0/lib/deprecation_tracker.rb:21:in `warn'
/home/runner/work/app_name/app_name/vendor/bundle/ruby/2.7.0/gems/sass-embedded-1.63.1-x86_64-linux-gnu/lib/sass/embedded/host/logger_registry.rb:22:in `block in initialize'

Possible Fix

Add in a rescue so even if the deprecation tracker receives some unexpected data shape, it doesn't blow up.

To Reproduce

Rails 4 installation

gemfile

gem 'sassc-embedded', '1.63.0'
gem 'sass-embedded', '1.63.1'
gem 'next_rails'

bundle install

bundle exec rake db:create db:migration db:seed

Additional Information

I will abide by the code of conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions