Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from "webexteamssdk" library to "webexpythonsdk" library #62

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

Sakthivel-Ramasamy
Copy link
Contributor

Migration from "webexteamssdk" library to "webexpythonsdk" library.

All instances of package name "webexteamssdk" is replaced with "webexpythonsdk". All instances of primary API object "WebexTeamsAPI" is replaced with "WebexAPI". All instances of access token environment variable "WEBEX_TEAMS_ACCESS_TOKEN" is replaced with "WEBEX_ACCESS_TOKEN".

Changes are inline with "https://webexcommunity.github.io/WebexPythonSDK/user/migrate.html" and tested with my local Webex bot (which resulted in no errors). Only thing is all instances of "webexteamssdk" references in local Webex bot had to be replaced with "webexpythonsdk".

Migration from "webexteamssdk" library to "webexpythonsdk" library.

All instances of package name "webexteamssdk" is replaced with "webexpythonsdk".
All instances of primary API object "WebexTeamsAPI" is replaced with "WebexAPI".
All instances of access token environment variable "WEBEX_TEAMS_ACCESS_TOKEN" is replaced with "WEBEX_ACCESS_TOKEN".

Changes are inline with "https://webexcommunity.github.io/WebexPythonSDK/user/migrate.html" and tested with my local Webex bot (which resulted in no errors). Only thing is all instances of "webexteamssdk" references in local Webex bot had to be replaced with "webexpythonsdk".
Copy link
Owner

@fbradyirl fbradyirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Could you run the bot locally and post some logs here to verify sending and receiving messages is ok with this code change. Both plain text and adaptive cards. Thanks.

@fbradyirl
Copy link
Owner

Python version is also now updated to Python 3.12 in main branch.

Point webexpythonsdk to the latest version
@Sakthivel-Ramasamy
Copy link
Contributor Author

Thanks for updating the Python version in main branch

@Sakthivel-Ramasamy
Copy link
Contributor Author

webex_bot_log_file.log

Log file attached. No issues noticed with the library change and code changes!

@fbradyirl fbradyirl merged commit 2ccc077 into fbradyirl:main Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants