Release CI Bug - stable
branch is updated when it shouldn't be
#5252
Labels
stable
branch is updated when it shouldn't be
#5252
Expected Behavior
The
update_stable_branch
job should only run when a feast release is triggered & committed.https://github.com/feast-dev/feast/blob/master/.github/workflows/release.yml#L189
Current Behavior
The gh action finishes successfully, but not release is actually triggered or commited to the feast repo. But, because the action completes w/o error, the remaining
update_stable_branch
job runs, but incorrectly retags the prior release.https://github.com/feast-dev/feast/actions/runs/14336350661/job/40184783409#step:9:86
As a result of this improper tagging, the current version tag is no longer tied to the proper branch and the next attempted release can't increment its version correctly.
Steps to reproduce
Specifications
Possible Solution
Add a boolean output to the
release
job in the release workflow file -https://github.com/feast-dev/feast/blob/master/.github/workflows/release.yml#L145
This new boolean field should be set to true only if a release is actually triggered.
The
update_stable_branch
job would only execute if this new release field is true.The text was updated successfully, but these errors were encountered: