Try support vim #46
Merged
Try support vim #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed middleware from client options in lsp-client for cleaner code. - Introduced DocumentStore class in lsp-server to manage document operations, including fallback methods for file reading and bean file listing. - Updated startServer function to utilize the new DocumentStore, improving document management in both browser and node environments. - Added support for reading files and listing bean files in the Node environment using fast-glob and fs/promises.
Open
- Updated references from 'manBeanFile' to 'mainBeanFile' in the DocumentStore class to ensure proper configuration handling. - Adjusted warning message to reflect the correct property name for user guidance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP Server Capability Handling and Fallback Improvements
Summary
This PR improves the LSP server's capability handling and adds proper fallback mechanisms for both browser and Node.js environments. It also refactors the server initialization flow to be more robust and type-safe.
This will make LSP Server ready to be used in vim.
Key Changes
Architecture Changes
DocumentStoreinitialization outside ofstartServerto allow platform-specific implementationsDocumentStoreInNodeclass for Node.js-specific implementationsisBrowserflagCapability Handling
ListBeanFileandFileReadcustom messagesfallbackListBeanFiles: Uses workspace folder to find bean filesfallbackFileRead: Provides platform-specific file reading implementationBrowser Support