forked from fga-eps-mds/2024.1-UnB-TV-Frontend
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US04 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ótipos de favoritar e salvar vídeo
…rop-down versao mobile
8 tasks
ErickMVdO
reviewed
Dec 13, 2024
Comment on lines
80
to
91
findVideoById(): void { | ||
// Aqui você deve definir como pegar o idVideo, talvez com route ou outro método | ||
// Como você já tem o idVideo, só faz a requisição | ||
this.videoService.findVideoById(this.idVideo).subscribe({ | ||
next: (data) => { | ||
// Aqui você pode armazenar o vídeo retornado, como já está no código original | ||
}, | ||
error: (err) => { | ||
console.error('Error fetching video details', err); | ||
}, | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um dos motivos para os testes estarem quebrando era que esta função não estava sendo usada para nada, apenas fazia a chamada para o service findVideoById. Portanto, removi a função do código.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Fizemos a implementação das funções de favoritar e assistir mais tarde à prévia do vídeo. Assim como o menu drop-down com as mesmas funções para dispositivos mobile.
Porque este Pull Request é necessário?
Permite que o usuário favorite ou salve o vídeo pela prévia no Desktop e pelo Mobile .
Critérios de Aceitação
Checklist
Resolve #1 .