fixed dependencies and incompatibilities, added unit tests

Author: fgsfds

src/Mods/Addons/Addon.cs

@@ -8,7 +8,7 @@ namespace Mods.Addons
     /// <summary>
     /// Base class for campaigns and maps
     /// </summary>
-    public class Addon : IAddon
+    public abstract class Addon : IAddon
     {
         /// <inheritdoc/>
         public required AddonTypeEnum Type { get; init; }

src/Mods/Providers/InstalledAddonsProvider.cs

@@ -425,6 +425,11 @@ newAddon.Version is not null &&
         {
             var isEnabled = !_config.DisabledAutoloadMods.Contains(id);
 
+            if (mainDef is not null)
+            {
+                ThrowHelper.ArgumentException($"Autoload mod can't have Main DEF");
+            }
+
             addon = new AutoloadMod()
             {
                 Id = id,
@@ -436,7 +441,7 @@ newAddon.Version is not null &&
                 Author = author,
                 IsEnabled = isEnabled,
                 PathToFile = pathToFile,
-                MainDef = mainDef,
+                MainDef = null,
                 AdditionalDefs = addDefs,
                 AdditionalCons = addCons,
                 SupportedGame = new(supportedGame, gameVersion, gameCrc),

src/Ports/Ports/BasePort.cs

@@ -214,28 +214,50 @@ protected bool ValidateAutoloadMod(AutoloadMod autoloadMod, IAddon campaign, Dic
 
             if (autoloadMod.DependentAddons is not null)
             {
-                foreach (var dep in autoloadMod.DependentAddons)
+                foreach (var dependantAddon in autoloadMod.DependentAddons)
                 {
-                    if (!addons.ContainsKey(new(dep.Key, dep.Value)) &&
-                        !campaign.Id.Equals(dep.Key, StringComparison.OrdinalIgnoreCase))
+                    foreach (var addon in addons)
                     {
-                        //skipping mod that doesn't have every dependency
-                        return false;
+                        if (dependantAddon.Key != addon.Key.Id)
+                        {
+                            continue;
+                        }
+                        else if (dependantAddon.Value is null)
+                        {
+                            return true;
+                        }
+                        else if (VersionComparer.Compare(addon.Key.Version, dependantAddon.Value))
+                        {
+                            return true;
+                        }
                     }
                 }
+
+                return false;
             }
 
             if (autoloadMod.IncompatibleAddons is not null)
             {
-                foreach (var dep in autoloadMod.IncompatibleAddons)
+                foreach (var incompatibleAddon in autoloadMod.IncompatibleAddons)
                 {
-                    if (addons.ContainsKey(new(dep.Key, dep.Value)) ||
-                        campaign.Id.Equals(dep.Key, StringComparison.OrdinalIgnoreCase))
+                    foreach (var addon in addons)
                     {
-                        //skipping incompatible mods
-                        return false;
+                        if (incompatibleAddon.Key != addon.Key.Id)
+                        {
+                            continue;
+                        }
+                        else if (incompatibleAddon.Value is null)
+                        {
+                            return false;
+                        }
+                        else if (VersionComparer.Compare(addon.Key.Version, incompatibleAddon.Value))
+                        {
+                            return false;
+                        }
                     }
                 }
+
+                return true;
             }
 
             return true;