Calendar signup form #221
Calendar signup form #221
Conversation
✅ Deploy Preview for calendar-gatsby ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@TheJuanAndOnly99 I need some help with this. I've added a signup form, but I get an error when trying to sign people up: ... perhaps we can discuss this in the new year when you get back? Also @mimiflynn fyi, I'm using Gatsby for this, so this incorporates some of your changes, probably out-of-sync. Let's see if we can work on closing these both out. |
|
Hi @psmulovics and @mimiflynn - could you test this preview out? This basically is a software version of emailing @TheJuanAndOnly99 and getting him to add your email on the event. Are you able to sign up to FINOS calendar events using the signup form? If so, I'll work a little more on a few improvements (e.g. email validation) thanks! |
|
@robmoffat I got the following error when trying to get an invite to the FDC3 working group:
|
|
Hi Mimi, Couple of things:
|
|
I just noticed that I got a lot of calendar invites to that meeting. Let me try others in different desktop environments. |
|
I think the issue was something about that FDC3 event. Other event invite signups have flowed to a success message without errors. |
|
ok, that's a relief. Let me see if I can recreate your issue |
|
Actually, can you tell me which working group it was? We have like 4 for FDC3... |
|
The 'FDC3 Standard Working Group' is the event that errored. I selected tomorrow's meeting. |
There was a problem hiding this comment.
@robmoffat mind pulling latest locally and fixing the conflicts?
|
@mimiflynn there you go. Still looking at the FDC3 meeting... will try and get back to it later today |
| setIsSubmitted(body) | ||
| }).catch(err => { | ||
| console.error(`Error updating calendar:`, err) | ||
| setIsSubmitted(`Error updating calendar: ${err}`) |
There was a problem hiding this comment.
For fun, I asked AI why it is a best practice to remove logs (a leading question I know):
It looks like it got the bulk of that answer from here.
Anyway, logs are for debugging during development, not for production. Their Its not only messy but easily offers information about the way an application works in a production environment where (perhaps not in this case) sensitive information might be revealed.
There was a problem hiding this comment.
In future work, we should separate the server code from the front with npm workspaces so the front and back end dependencies and applications are independent.
There was a problem hiding this comment.
but this Is how Gatsby organises things.
There was a problem hiding this comment.
I see, my mistake, I thought this was a node app, I should have known it was the API call.
| <div className="signup form-container"><pre>{isSubmitted}</pre></div> | ||
| ) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
This nested else if else is hard to read. Perhaps move the markup to a functional component or method that is then composed within the if else logic?
|
ok, I've updated this to support three conditions - working, failed and timing out. |
|
I was also able to get the event invite even though it returned an error for the FDC3 meeting. |
|
@mimiflynn so are we good then? |
Yeah it seems like it's just this one meeting, and you should get a message like: 
right? |
|
I'll take out the logs later when we know this signup form is working consistently. |
|
@robmoffat are we waiting for additional approval? I'm excited to get this out! |
me too. I used it with the OSR SIG the other day. No one complained. I've also shopped it round for people to try in FINOS. I've got a meeting with @TheJuanAndOnly in a minute we'll discuss merging it then |
Creating a first PR to look at event signup workflow.
Implements #154