-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Added events search (+Added Fix) (#14) #98
Conversation
Hi @gautamjuyal sorry for the delay. Could you resolve the conflicts? I'll review after and hopefully we can merge this time! |
Sure. I'll start resolving the conflicts. There's one thing I wanted to ask, do we have any way to deploy a branch, so that we test the changes in the branch first? |
@TheJuanAndOnly99 just checked the build steps, I think I've figured why it breaks on deployment. We run "Get events from google API" after we run the build command. |
@gautamjuyal I cannot send a PR to your branch. Can you either grant me permission or change the action to be like this:
Thanks! |
There is an error with GPG this time gpg: gcry_kdf_derive failed: Invalid data
gpg: decryption failed: No secret key
Error: Process completed with exit code 2. |
I think this issue persists because of PASSPHRASE secret getting restricted to selected branches. I tried using my local passphrase but it doesn't work, since the PR has the original |
Hey @gautamjuyal yes you are correct the secret is not shared across branches. I will test this locally and merge if all looks good. |
Thanks again @gautamjuyal! Sorry for the delay. |
Fixes #14
This PR adds events search feature to the calendar
Changes/Updates
events.json
toFullCalendar
component.events.json
is now manually imported toApp.jsx
.root
directory tosrc
directory in development. Same has been updated in theReadme.md
file.Features
Screenshots
Calendar

Calendar (when searched for an event)

Dark Mode

Mobile view

Suggestions and improvements
Since this is the first iteration of search in the project it might not be perfect, thus any improvements and suggestions are very much appreciated
Caveats
Even though import statement is changed (which was causing error), it is still unsure whether the change fixes the issue. Will need to be tested on deployment.