JEAN BAPTISTE ZIADE CorporateActionEvent_Enrichement_FRAGMOS #3366
Conversation
CorporateActionEvent_Enrichement_FRAGMOS
✅ Deploy Preview for finos-cdm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
this one REPLACES #3220 |
|
not sure what is correct status value for this PR ? it has been discussed/approved in both DerWG and CRWG since then, it is pending review by Maintainers is that Ok as below ?
|
There was a problem hiding this comment.
@JBZ-Fragmos Thank you very much for your comprehensive PR, which was previously approved for contribution by the WG.
Please find detailed technical review comments.
Could you also confirm that this is meant for v7 and doesn't need to go into v6 (Prod)?
|
hi @lolabeis about your question on CDM version at stake, whether v7 or v6 :
yet i see have created current PR in v6... is that possible for you to handle the upgrade from v6 to v7 with any backend process at you end ; or should I manually re-copy my PR under v7 then push it again, etc. ? |
|
@JBZ-Fragmos |
|
What is being released? updates in accordance with Leo suggestions and feebacks Note This comment was generated via Rosetta. |
|
Duplicated (against 6.x) in #3578 |
|
Hi @JBZ-Fragmos For some reason, I'm not seeing your latest commit, the changes I see on this PR are still the ones from Feb. Can I ask you to take it with our support, to investigate why we don't seem to have captured your latest commit? |
|
[like] Jean-Baptiste Ziadé reacted to your message:
…________________________________
From: lolabeis ***@***.***>
Sent: Wednesday, March 26, 2025 4:56:57 PM
To: finos/common-domain-model ***@***.***>
Cc: Jean-Baptiste Ziadé ***@***.***>; Mention ***@***.***>
Subject: Re: [finos/common-domain-model] JEAN BAPTISTE ZIADE CorporateActionEvent_Enrichement_FRAGMOS (PR #3366)
Hi @JBZ-Fragmos<https://github.com/JBZ-Fragmos> For some reason, I'm not seeing your latest commit, the changes I see on this PR are still the ones from Feb. Can I ask you to take it with our support, to investigate why we don't seem to have captured your latest commit?
—
Reply to this email directly, view it on GitHub<#3366 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2POORZVEETJLNR4DHST2WLE4TAVCNFSM6AAAAABWMNTS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJVGEYDANRQGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[lolabeis]lolabeis left a comment (finos/common-domain-model#3366)<#3366 (comment)>
Hi @JBZ-Fragmos<https://github.com/JBZ-Fragmos> For some reason, I'm not seeing your latest commit, the changes I see on this PR are still the ones from Feb. Can I ask you to take it with our support, to investigate why we don't seem to have captured your latest commit?
—
Reply to this email directly, view it on GitHub<#3366 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2POORZVEETJLNR4DHST2WLE4TAVCNFSM6AAAAABWMNTS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJVGEYDANRQGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Scheduled for the CRWG on 1 April 2025 (#3598) but presenter not available. |
Hi @JBZ-Fragmos, do you need to discuss this PR on the next CRWG? The issue #3237 has been approved on the previous WG |
|
Hi @JBZ-Fragmos Just following-up on the above, have you investigated your issue where we can't see your commit in GitHub with our support team? Your contribution is currently scheduled at the next CRWG (on 15/2), so would be great to have the PR ready by then. |
|
@lolabeis have just pushed contrib again righht now... can you see this commit in GitHub ? |
Hi, the master branch has moved on since the initial contribution in February so a second PR was created. The new PR is here: #3637 and all new commits will be visible here. |
|
Still it does not work... do not know why, have notified Support...
***@***.***
De : CDM-ReleaseManagement-OT ***@***.***>
Envoyé : jeudi 10 avril 2025 18:21
À : finos/common-domain-model ***@***.***>
Cc : Jean-Baptiste Ziadé ***@***.***>; Mention ***@***.***>
Objet : Re: [finos/common-domain-model] JEAN BAPTISTE ZIADE CorporateActionEvent_Enrichement_FRAGMOS (PR #3366)
@lolabeis<https://github.com/lolabeis> have just pushed contrib again righht now... can you see this commit in GitHub ? will ask support team to check as well...
Hi, the master branch has moved on since the initial contribution in February so a second PR was created. The new PR is here: #3637<#3637> and all new commits will be visible here.
-
Reply to this email directly, view it on GitHub<#3366 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2PKWUT4AVWNY2LNCAG32Y2LAJAVCNFSM6AAAAABWMNTS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJUGQZDEMZVGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
[https://avatars.githubusercontent.com/u/203143130?s=20&v=4]CDM-ReleaseManagement-OT left a comment (finos/common-domain-model#3366)<#3366 (comment)>
@lolabeis<https://github.com/lolabeis> have just pushed contrib again righht now... can you see this commit in GitHub ? will ask support team to check as well...
Hi, the master branch has moved on since the initial contribution in February so a second PR was created. The new PR is here: #3637<#3637> and all new commits will be visible here.
-
Reply to this email directly, view it on GitHub<#3366 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2PKWUT4AVWNY2LNCAG32Y2LAJAVCNFSM6AAAAABWMNTS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJUGQZDEMZVGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
|
Closing this PR as review is being addressed in #3637 - All comments here have been addressed. |
lolabeis
deleted the
jbziade_auth0_5fe1be69c40973007616a588-CorporateAction_Enrichment_FRAGMOS
branch
|
[like] Jean-Baptiste Ziadé reacted to your message:
…________________________________
From: lolabeis ***@***.***>
Sent: Friday, April 11, 2025 1:20:12 PM
To: finos/common-domain-model ***@***.***>
Cc: Jean-Baptiste Ziadé ***@***.***>; Mention ***@***.***>
Subject: Re: [finos/common-domain-model] JEAN BAPTISTE ZIADE CorporateActionEvent_Enrichement_FRAGMOS (PR #3366)
Closing this PR as review is being addressed in #3637<#3637> - All comments here have been addressed.
—
Reply to this email directly, view it on GitHub<#3366 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2PMN5F6K5FBW5KXTYOD2Y66QZAVCNFSM6AAAAABWMNTS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJWHEYDCMJTGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[https://avatars.githubusercontent.com/u/29451984?s=20&v=4]lolabeis left a comment (finos/common-domain-model#3366)<#3366 (comment)>
Closing this PR as review is being addressed in #3637<#3637> - All comments here have been addressed.
—
Reply to this email directly, view it on GitHub<#3366 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWFL2PMN5F6K5FBW5KXTYOD2Y66QZAVCNFSM6AAAAABWMNTS3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJWHEYDCMJTGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.