remove static references

finos · Jan 23, 2024 · 9976582 · 9976582
1 parent d082408
commit 9976582
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/rosetta-runtime/src/main/java/com/rosetta/model/lib/qualify/QualifyResult.java b/rosetta-runtime/src/main/java/com/rosetta/model/lib/qualify/QualifyResult.java
@@ -121,7 +121,7 @@ static ExpressionDataRuleResult fromDataRule(ValidationResult result, String ope
 					Type.DataRule,
 					null,
 					Optional.ofNullable(operator), 
-					ValidationResult.isSuccess(), 
+					result.isSuccess(), 
 					result.getFailureReason().orElse(""));
 		}
 

diff --git a/rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ValidationResult.java b/rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ValidationResult.java
@@ -5,12 +5,11 @@
 import java.util.Optional;
 
 public class ValidationResult{
-	private static boolean success;
+	private boolean success;
 	private Optional<String> failureReason;
 	private RosettaPath path;
 	private Optional<ValidationData> data;
 
-	@SuppressWarnings("static-access")
 	public ValidationResult(boolean success, String failureReason, RosettaPath path, ValidationData data) {
 		this.success = success;
 		this.failureReason = failureReason!=""?Optional.ofNullable(failureReason):Optional.empty();
@@ -26,7 +25,7 @@ public static ValidationResult failure(RosettaPath path, String failureReason, V
 		return new ValidationResult(false, failureReason, path, data);
 	}
 
-	public static boolean isSuccess() {
+	public boolean isSuccess() {
 		return success;
 	}