Story- 711 new data structure regulation validation #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PayalKhanna
changed the title
This was referenced Jan 19, 2024
SimonCockx
reviewed
Jan 22, 2024
rosetta-lang/src/main/java/com/regnosys/rosetta/generator/java/object/ValidatorsGenerator.xtend
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-lang/src/main/java/com/regnosys/rosetta/generator/RosettaGenerator.xtend
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
...ta-lang/src/main/java/com/regnosys/rosetta/generator/java/validator/ValidatorGenerator.xtend
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ChoiceRuleValidationMethod.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ModelValidationResult.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ModelValidationResult.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/NumberValidationData.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/StringValidationData.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ValidationData.java
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ValidationResult.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
rosetta-runtime/src/main/java/com/rosetta/model/lib/validation/ValidationResult.java
Outdated
Show resolved
Hide resolved
SimonCockx
reviewed
Jan 22, 2024
|
|
||
| static <T> ValidationResult<T> success(String name, ValidationType validationType, String modelObjectName, RosettaPath path, String definition) { | ||
| return new ModelValidationResult<>(name, validationType, modelObjectName, path, definition, Optional.empty()); | ||
| public static ValidationResult success(RosettaPath path) { |
There was a problem hiding this comment.
I have been thinking a bit about backwards compatibility.. I fear that this class is gonna cause problems.
Old workspaces will still contain generated code of the form
ValidationResult<Foo> result = ValidationResult.success("foo", ValidationType.CARDINALITY, "Foo", path, "definition");
which will suddenly stop working because of multiple reasons:
- The type parameter
<Foo>is now invalid, since we got rid of the genericTtype. - The method
ValidationResult.success(String, ValidationType, String, RosettaPath, String)does not exist anymore. - The type
ValidationResult.ValidationTypedoes not exist anymore.
I'm not sure yet about what our best course of action is.
SimonCockx
reviewed
Jan 22, 2024
| @@ -234,14 +231,14 @@ public Validator<? super Key> validator() { | |||
| return new Validator<Key>() { | |||
There was a problem hiding this comment.
I think we should deprecate this one too, and rather create a KeyValidator implements RosettaModelObjectValidator<Key> using our new infrastructure.
SimonCockx
reviewed
Jan 22, 2024
| Optional.ofNullable(operator), | ||
| result.isSuccess(), |
There was a problem hiding this comment.
TODO: think about these changes
SimonCockx
reviewed
Jan 22, 2024
There was a problem hiding this comment.
TODO:
- add tests that use the compiled code.
- add tests for inheritance (e.g.,
type Foo extends Bar)
SimonCockx
reviewed
Jan 22, 2024
| ''' | ||
| public class «data.name»Validator implements «RosettaModelObjectValidator»<«modelPojo»>{ | ||
| «FOR con : data.conditions» | ||
| @«Inject» protected «new GeneratedJavaClass(root.condition, con.conditionName(data).toConditionJavaType, Object)» «con.conditionName(data).toFirstLower» ; |
There was a problem hiding this comment.
Let's clean up this line together. new GeneratedJavaClass(root.condition, con.conditionName(data).toConditionJavaType, Object) should be a utility method inside JavaTypeTranslator.
There was a problem hiding this comment.
About the name «con.conditionName(data).toFirstLower» - this may fail to generate valid Java code in certain edge cases, which I haven't explained to you yet. Remind me to explain usage of the JavaScope class to you. :)
|
close replaced with #722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Data structure to hold Validation results for Regulation Diagnostic panel
Type of change
Please delete options that are not relevant.