Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finos prep #734

Merged
merged 13 commits into from
Apr 16, 2024
Merged

Finos prep #734

merged 13 commits into from
Apr 16, 2024

Conversation

minesh-s-patel
Copy link
Contributor

@minesh-s-patel minesh-s-patel commented Mar 13, 2024

Contribution for Rosetta DSL to FINOS

This PR applied the FINOS Software Blueprint to an existing repo

https://community.finos.org/docs/collaboration-infrastructure/#how-to-use-this-blueprint

ja6a-regnosys and others added 6 commits February 8, 2024 16:13
# Conflicts:
#	README.md
#	rosetta-lang/com.regnosys.rosetta.iml
#	rosetta-lang/src/main/java/com/regnosys/rosetta/resource/IndexedFeature.java
#	setup-for-developers.md
@minesh-s-patel minesh-s-patel self-assigned this Mar 20, 2024
@minesh-s-patel minesh-s-patel added the awaiting feedback It is unclear what the issue is describing and needs feedback label Mar 20, 2024
@maoo
Copy link
Member

maoo commented Mar 20, 2024

Looks good! Few items left, then we should be ready to transfer the repo...

README.md Outdated

A complete *Software Development Kit (SDK)* also called [Rosetta](https://ui.rosetta-technology.io/) is provided to help industry participants to create, edit or extend models using the Rosetta DSL. Rosetta also provides integration tools designed to facilitate firms' adoption and implementation of models within their own technology architecture.
*Need an ICLA? Unsure if you are covered under an existing CCLA? Email [help@finos.org](mailto:help@finos.org)*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minesh-s-patel - I'd remove the Need an ICLA? part

Copy link
Member

@maoo maoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@minesh-s-patel minesh-s-patel merged commit 66b10f0 into master Apr 16, 2024
11 checks passed
@minesh-s-patel minesh-s-patel deleted the finos-prep branch April 16, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback It is unclear what the issue is describing and needs feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants