Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitution group backwards compatibility #933

Merged
merged 9 commits into from
Feb 25, 2025
Merged

Substitution group backwards compatibility #933

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2a6026
Substitution group fix
SimonCockx Feb 21, 2025
0d6fc13
Merge branch 'main' into substitution-group-fix
SimonCockx Feb 21, 2025
7c97f09
Merge branch 'main' into substitution-group-fix
SimonCockx Feb 21, 2025
8ee13e0
Backwards compatibility
SimonCockx Feb 21, 2025
08d17db
t push
SimonCockx Feb 21, 2025
5fbef73
Backwards compatibility
SimonCockx Feb 21, 2025
726983e
Backwards compatibility
SimonCockx Feb 24, 2025
3aa205e
Merge branch 'main' into substitution-group-fix
SimonCockx Feb 24, 2025
8415f7a
Update RosettaXMLConfiguration.java
SimonCockx Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rosetta-runtime/src/main/java/com/rosetta/util/serialisation/RosettaXMLConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ public List<ModelSymbolId> getSubstitutionsFor(String substitutionGroup) {
.map(e -> e.getKey())
.collect(Collectors.toList());
}
@Deprecated // use getSubstitutionsFor instead.
public List<ModelSymbolId> getSubstitutionsForType(ModelSymbolId symbolId) {
return typeConfigMap.entrySet().stream()
.filter(e -> e.getValue().getSubstitutionFor().map(t -> t.equals(symbolId)).orElse(false))
.map(e -> e.getKey())
.collect(Collectors.toList());
}

@Override
public int hashCode() {
Expand Down
Loading