-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init SwiftUI library for FirebaseAuthSwiftUI #1237
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Had one architecture question for consideration.
func onCredentialReceived(_ credential: AuthCredential) | ||
func onCredentialLinked(_ credential: AuthCredential) | ||
// func onMFARequired(_ resolver: MultiFactorResolver) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're targeting this toward SwiftUI users, what do you think of adding a @StateObject
that tracks the auth state so consumers can use it directly instead of having to set up their own wrapper? This could be the auth provider itself or a separate object that's managed by the auth provider, or a default implementation of the AuthListenerProtocol
.
Work in progress, no functionality at the moment. Just setting up the project:
FirebaseAuthSwiftUI
(this has some basic types/class which will be needed later) &FirebaseAuthEmailSwiftUI
for email provider functionality.samples/swiftui
which pulls in the above libraries for developing.