Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init SwiftUI library for FirebaseAuthSwiftUI #1237

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 18, 2025

Work in progress, no functionality at the moment. Just setting up the project:

  • Setup a separate directory for SwiftUI libraries.
  • Created two libraries; FirebaseAuthSwiftUI (this has some basic types/class which will be needed later) & FirebaseAuthEmailSwiftUI for email provider functionality.
  • Created a SwiftUI example app in samples/swiftui which pulls in the above libraries for developing.

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Had one architecture question for consideration.

func onCredentialReceived(_ credential: AuthCredential)
func onCredentialLinked(_ credential: AuthCredential)
// func onMFARequired(_ resolver: MultiFactorResolver)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're targeting this toward SwiftUI users, what do you think of adding a @StateObject that tracks the auth state so consumers can use it directly instead of having to set up their own wrapper? This could be the auth provider itself or a separate object that's managed by the auth provider, or a default implementation of the AuthListenerProtocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants