Skip to content

Commit 1abe627

Browse files
Update to clang-format@20 and apply updated styling.
This commit updates the repository to use clang-format version 20. The scripts clang-format not found, install with 'brew install clang-format' and python --version: Python 3.12.3 were updated to use this version. Also, the file was updated. The script clang-format not found, install with 'brew install clang-format' was run, but due to the unavailability of the test environment, I could not check if the changes introduced regressions.
1 parent f2d1b72 commit 1abe627

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ To develop Firebase software, **install**:
132132
To install [clang-format] and [mint] using [Homebrew]:
133133

134134
```console
135-
brew install clang-format@19
135+
brew install clang-format@20
136136
brew install mint
137137
```
138138

scripts/setup_check.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ fi
3535

3636
# install clang-format
3737
brew update
38-
brew install clang-format@19
38+
brew install clang-format@20
3939

4040
# mint installs tools from Mintfile on demand.
4141
brew install mint

scripts/style.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ version="${version/ (*)/}"
5656
version="${version/.*/}"
5757

5858
case "$version" in
59-
19)
59+
20)
6060
;;
6161
google3-trunk)
6262
echo "Please use a publicly released clang-format; a recent LLVM release"
@@ -65,13 +65,12 @@ case "$version" in
6565
exit 1
6666
;;
6767
*)
68-
echo "Please upgrade to clang-format version 19."
68+
echo "Please upgrade to clang-format version 20."
6969
echo "If it's installed via homebrew you can run:"
7070
echo "brew upgrade clang-format"
7171
exit 1
7272
;;
7373
esac
74-
7574
# Ensure that tools in `Mintfile` are installed locally to avoid permissions
7675
# problems that would otherwise arise from the default of installing in
7776
# /usr/local.
@@ -193,6 +192,7 @@ for f in $files; do
193192
"$clang_format_bin" "${clang_options[@]}" "$f" | grep "<replacement " > /dev/null
194193
fi
195194

195+
196196
if [[ "$test_only" == true && $? -ne 1 ]]; then
197197
echo "$f needs formatting."
198198
needs_formatting=true

0 commit comments

Comments
 (0)