Skip to content

Commit a4dfa01

Browse files
committed
[vertex-ai] App Version for AI Monitoring
1 parent e22db2a commit a4dfa01

File tree

2 files changed

+14
-7
lines changed

2 files changed

+14
-7
lines changed

FirebaseVertexAI/Sources/GenerativeAIService.swift

+6-4
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,12 @@ struct GenerativeAIService {
193193
urlRequest.setValue("Firebase \(authToken)", forHTTPHeaderField: "Authorization")
194194
}
195195

196-
// TODO: wait for release approval.
197-
// if firebaseInfo.app.isDataCollectionDefaultEnabled {
198-
// urlRequest.setValue(firebaseInfo.googleAppID, forHTTPHeaderField: "X-Firebase-AppId")
199-
// }
196+
if firebaseInfo.app.isDataCollectionDefaultEnabled {
197+
urlRequest.setValue(firebaseInfo.googleAppID, forHTTPHeaderField: "X-Firebase-AppId")
198+
let appVersion = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ??
199+
"unknown"
200+
urlRequest.setValue(appVersion, forHTTPHeaderField: "X-Firebase-AppVersion")
201+
}
200202

201203
let encoder = JSONEncoder()
202204
urlRequest.httpBody = try encoder.encode(request)

FirebaseVertexAI/Tests/Unit/GenerativeModelTests.swift

+8-3
Original file line numberDiff line numberDiff line change
@@ -1530,9 +1530,14 @@ final class GenerativeModelTests: XCTestCase {
15301530
XCTAssert(apiClientTags.contains(GenerativeAIService.languageTag))
15311531
XCTAssert(apiClientTags.contains(GenerativeAIService.firebaseVersionTag))
15321532
XCTAssertEqual(request.value(forHTTPHeaderField: "X-Firebase-AppCheck"), appCheckToken)
1533-
// TODO: Wait for release approval
1534-
// let googleAppID = request.value(forHTTPHeaderField: "X-Firebase-AppId")
1535-
// XCTAssertEqual(googleAppID, dataCollection ? "My app ID" : nil)
1533+
1534+
let googleAppID = request.value(forHTTPHeaderField: "X-Firebase-AppId")
1535+
let appVersion = request.value(forHTTPHeaderField: "X-Firebase-AppVersion")
1536+
let expectedAppVersion =
1537+
try? XCTUnwrap(Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String)
1538+
XCTAssertEqual(googleAppID, dataCollection ? "My app ID" : nil)
1539+
XCTAssertEqual(appVersion, dataCollection ? expectedAppVersion : nil)
1540+
15361541
if let authToken {
15371542
XCTAssertEqual(request.value(forHTTPHeaderField: "Authorization"), "Firebase \(authToken)")
15381543
} else {

0 commit comments

Comments
 (0)