Commit a4dfa01 1 parent e22db2a commit a4dfa01 Copy full SHA for a4dfa01
File tree 2 files changed +14
-7
lines changed
2 files changed +14
-7
lines changed Original file line number Diff line number Diff line change @@ -193,10 +193,12 @@ struct GenerativeAIService {
193
193
urlRequest. setValue ( " Firebase \( authToken) " , forHTTPHeaderField: " Authorization " )
194
194
}
195
195
196
- // TODO: wait for release approval.
197
- // if firebaseInfo.app.isDataCollectionDefaultEnabled {
198
- // urlRequest.setValue(firebaseInfo.googleAppID, forHTTPHeaderField: "X-Firebase-AppId")
199
- // }
196
+ if firebaseInfo. app. isDataCollectionDefaultEnabled {
197
+ urlRequest. setValue ( firebaseInfo. googleAppID, forHTTPHeaderField: " X-Firebase-AppId " )
198
+ let appVersion = Bundle . main. infoDictionary ? [ " CFBundleShortVersionString " ] as? String ??
199
+ " unknown "
200
+ urlRequest. setValue ( appVersion, forHTTPHeaderField: " X-Firebase-AppVersion " )
201
+ }
200
202
201
203
let encoder = JSONEncoder ( )
202
204
urlRequest. httpBody = try encoder. encode ( request)
Original file line number Diff line number Diff line change @@ -1530,9 +1530,14 @@ final class GenerativeModelTests: XCTestCase {
1530
1530
XCTAssert ( apiClientTags. contains ( GenerativeAIService . languageTag) )
1531
1531
XCTAssert ( apiClientTags. contains ( GenerativeAIService . firebaseVersionTag) )
1532
1532
XCTAssertEqual ( request. value ( forHTTPHeaderField: " X-Firebase-AppCheck " ) , appCheckToken)
1533
- // TODO: Wait for release approval
1534
- // let googleAppID = request.value(forHTTPHeaderField: "X-Firebase-AppId")
1535
- // XCTAssertEqual(googleAppID, dataCollection ? "My app ID" : nil)
1533
+
1534
+ let googleAppID = request. value ( forHTTPHeaderField: " X-Firebase-AppId " )
1535
+ let appVersion = request. value ( forHTTPHeaderField: " X-Firebase-AppVersion " )
1536
+ let expectedAppVersion =
1537
+ try ? XCTUnwrap ( Bundle . main. infoDictionary ? [ " CFBundleShortVersionString " ] as? String )
1538
+ XCTAssertEqual ( googleAppID, dataCollection ? " My app ID " : nil )
1539
+ XCTAssertEqual ( appVersion, dataCollection ? expectedAppVersion : nil )
1540
+
1536
1541
if let authToken {
1537
1542
XCTAssertEqual ( request. value ( forHTTPHeaderField: " Authorization " ) , " Firebase \( authToken) " )
1538
1543
} else {
You can’t perform that action at this time.
0 commit comments