Merge branch 'main'

#Conflicts:
#	FirebaseRemoteConfig/CHANGELOG.md

Author: tusharkhandelwal8

.github/workflows/abtesting.yml

@@ -120,6 +120,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/auth.yml

@@ -141,6 +141,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS spm'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/check.yml

@@ -15,7 +15,7 @@ jobs:
   check:
     # Don't run on private repo.
     if: github.repository == 'Firebase/firebase-ios-sdk'
-    runs-on: macos-14
+    runs-on: ubuntu-latest
     env:
       MINT_PATH: ${{ github.workspace }}/mint
     steps:
@@ -33,7 +33,13 @@ jobs:
         restore-keys: ${{ runner.os }}-mint-
 
     - name: Setup check
-      run:  scripts/setup_check.sh
+      run:  |
+        eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
+        scripts/setup_check.sh
 
     - name: Check
-      run:  scripts/check.sh --test-only
+      run:  |
+        eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
+        # Add Homebrew clang-format to first in PATH
+        export PATH="/home/linuxbrew/.linuxbrew/opt/clang-format/bin:$PATH"
+        scripts/check.sh --test-only

.github/workflows/core.yml

@@ -101,6 +101,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - name: Unit Tests

.github/workflows/crashlytics.yml

@@ -116,6 +116,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/generate_issues.yml

@@ -8,6 +8,10 @@ on:
   schedule:
     # Run every day at 4am (PST) - cron uses UTC times
     - cron:  '0 12 * * *'
+
+permissions:
+  issues: write
+
 jobs:
   generate_an_issue:
     # Don't run on private repo.

.github/workflows/mlmodeldownloader.yml

@@ -131,6 +131,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - name: Unit Tests

.github/workflows/remoteconfig.yml

@@ -155,6 +155,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - name: Unit Tests

.github/workflows/sessions.yml

@@ -111,6 +111,9 @@ jobs:
         key: ${{needs.spm-package-resolved.outputs.cache_key}}
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3

.github/workflows/vertexai.yml

@@ -81,6 +81,9 @@ jobs:
       run: scripts/update_vertexai_responses.sh
     - name: Xcode
       run: sudo xcode-select -s /Applications/${{ matrix.xcode }}.app/Contents/Developer
+    - name: Install visionOS, if needed.
+      if: matrix.target == 'visionOS'
+      run: xcodebuild -downloadPlatform visionOS
     - name: Initialize xcodebuild
       run: scripts/setup_spm_tests.sh
     - uses: nick-fields/retry@v3
@@ -137,11 +140,10 @@ jobs:
             xcode: Xcode_16.2
             swift_version: 5.9
             warnings:
-          #TODO: Fix remaining warning in GenerativeAIService and remove --allow-warnings.
           - os: macos-15
             xcode: Xcode_16.2
             swift_version: 6.0
-            warnings: --allow-warnings
+            warnings:
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v4

CONTRIBUTING.md

@@ -132,7 +132,7 @@ To develop Firebase software, **install**:
    To install [clang-format] and [mint] using [Homebrew]:
 
     ```console
-    brew install clang-format@19
+    brew install clang-format@20
     brew install mint
     ```
 

Crashlytics/Crashlytics/Components/FIRCLSApplication.h

@@ -83,10 +83,6 @@ UIApplication* FIRCLSApplicationSharedInstance(void);
 id FIRCLSApplicationSharedInstance(void);
 #endif
 
-void FIRCLSApplicationOpenURL(NSURL* url,
-                              NSExtensionContext* extensionContext,
-                              void (^completionBlock)(BOOL success));
-
 id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason);
 void FIRCLSApplicationEndActivity(id<NSObject> activity);
 

Crashlytics/Crashlytics/Components/FIRCLSApplication.m

@@ -155,32 +155,6 @@ id FIRCLSApplicationSharedInstance(void) {
 }
 #endif
 
-void FIRCLSApplicationOpenURL(NSURL* url,
-                              NSExtensionContext* extensionContext,
-                              void (^completionBlock)(BOOL success)) {
-  if (extensionContext) {
-    [extensionContext openURL:url completionHandler:completionBlock];
-    return;
-  }
-
-  BOOL result = NO;
-
-#if TARGET_OS_IOS
-  // What's going on here is the value returned is a scalar, but we really need an object to
-  // call this dynamically. Hoops must be jumped.
-  NSInvocationOperation* op =
-      [[NSInvocationOperation alloc] initWithTarget:FIRCLSApplicationSharedInstance()
-                                           selector:@selector(openURL:)
-                                             object:url];
-  [op start];
-  [op.result getValue:&result];
-#elif CLS_TARGET_OS_OSX
-  result = [[NSClassFromString(@"NSWorkspace") sharedWorkspace] openURL:url];
-#endif
-
-  completionBlock(result);
-}
-
 id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason) {
   if ([[NSProcessInfo processInfo] respondsToSelector:@selector(beginActivityWithOptions:
                                                                                   reason:)]) {

FirebaseFunctions/Sources/Functions.swift

@@ -401,9 +401,9 @@ enum FunctionsConstants {
 
     do {
       let rawData = try await fetcher.beginFetch()
-      return try callableResult(fromResponseData: rawData)
+      return try callableResult(fromResponseData: rawData, endpointURL: url)
     } catch {
-      throw processedError(fromResponseError: error)
+      throw processedError(fromResponseError: error, endpointURL: url)
     }
   }
 
@@ -454,10 +454,10 @@ enum FunctionsConstants {
     fetcher.beginFetch { [self] data, error in
       let result: Result<HTTPSCallableResult, any Error>
       if let error {
-        result = .failure(processedError(fromResponseError: error))
+        result = .failure(processedError(fromResponseError: error, endpointURL: url))
       } else if let data {
         do {
-          result = try .success(callableResult(fromResponseData: data))
+          result = try .success(callableResult(fromResponseData: data, endpointURL: url))
         } catch {
           result = .failure(error)
         }
@@ -523,11 +523,14 @@ enum FunctionsConstants {
     return fetcher
   }
 
-  private func processedError(fromResponseError error: any Error) -> any Error {
+  private func processedError(fromResponseError error: any Error,
+                              endpointURL url: URL) -> any Error {
     let error = error as NSError
     let localError: (any Error)? = if error.domain == kGTMSessionFetcherStatusDomain {
       FunctionsError(
         httpStatusCode: error.code,
+        region: region,
+        url: url,
         body: error.userInfo["data"] as? Data,
         serializer: serializer
       )
@@ -538,16 +541,23 @@ enum FunctionsConstants {
     return localError ?? error
   }
 
-  private func callableResult(fromResponseData data: Data) throws -> HTTPSCallableResult {
-    let processedData = try processedData(fromResponseData: data)
+  private func callableResult(fromResponseData data: Data,
+                              endpointURL url: URL) throws -> HTTPSCallableResult {
+    let processedData = try processedData(fromResponseData: data, endpointURL: url)
     let json = try responseDataJSON(from: processedData)
     let payload = try serializer.decode(json)
     return HTTPSCallableResult(data: payload)
   }
 
-  private func processedData(fromResponseData data: Data) throws -> Data {
+  private func processedData(fromResponseData data: Data, endpointURL url: URL) throws -> Data {
     // `data` might specify a custom error. If so, throw the error.
-    if let bodyError = FunctionsError(httpStatusCode: 200, body: data, serializer: serializer) {
+    if let bodyError = FunctionsError(
+      httpStatusCode: 200,
+      region: region,
+      url: url,
+      body: data,
+      serializer: serializer
+    ) {
       throw bodyError
     }
 

FirebaseFunctions/Sources/FunctionsError.swift

@@ -180,7 +180,8 @@ struct FunctionsError: CustomNSError {
   ///     }
   ///     ```
   ///   - serializer: The `FunctionsSerializer` used to decode `details` in the error body.
-  init?(httpStatusCode: Int, body: Data?, serializer: FunctionsSerializer) {
+  init?(httpStatusCode: Int, region: String, url: URL, body: Data?,
+        serializer: FunctionsSerializer) {
     // Start with reasonable defaults from the status code.
     var code = FunctionsErrorCode(httpStatusCode: httpStatusCode)
     var description = Self.errorDescription(from: code)
@@ -224,6 +225,8 @@ struct FunctionsError: CustomNSError {
 
     var userInfo = [String: Any]()
     userInfo[NSLocalizedDescriptionKey] = description
+    userInfo["region"] = region
+    userInfo["url"] = url
     if let details {
       userInfo[FunctionsErrorDetailsKey] = details
     }

FirebaseFunctions/Sources/Internal/FunctionsSerializer.swift

@@ -31,28 +31,23 @@ extension FunctionsSerializer {
 final class FunctionsSerializer {
   // MARK: - Internal APIs
 
-  func encode(_ object: Any) throws -> AnyObject {
+  func encode(_ object: Any) throws -> Any {
     if object is NSNull {
-      return object as AnyObject
+      return object
     } else if object is NSNumber {
       return try encodeNumber(object as! NSNumber)
     } else if object is NSString {
-      return object as AnyObject
-    } else if object is NSDictionary {
-      let dict = object as! NSDictionary
+      return object
+    } else if let dict = object as? NSDictionary {
       let encoded = NSMutableDictionary()
       try dict.forEach { key, value in
         encoded[key] = try encode(value)
       }
       return encoded
-    } else if object is NSArray {
-      let array = object as! NSArray
-      let encoded = NSMutableArray()
-      try array.forEach { element in
-        try encoded.add(encode(element))
+    } else if let array = object as? NSArray {
+      return try array.map { element in
+        try encode(element)
       }
-      return encoded
-
     } else {
       throw Error.unsupportedType(typeName: typeName(of: object))
     }