-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functions] Add support for streamable cloud functions #14395
Conversation
Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Add Json capabilities to parse an HTTP result back and forth. Updating Unit tests.
Cleanup
Add doc for processResponseDataForStreamableContent.
Update func to have a callback. Update UnitTests
Remove test.
Fetch Main branch.
…/firebase-ios-sdk into iOS-Stremable-Functions
Updated to renamed code. From callableResultFromResponse to callableResult
Run style.sh
Fix concurrency " mutation of captured var 'response' in concurrently-executing code" and typos.
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
This file is not needed.
This file is not needed.
Add throws Remove DO - CATCH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Just sending a few comments along before I head out. (Didn't see anything that didn't LGTM so far, just haven't finished reviewing yet)
/gemini please review |
Okay, I will review the pull request now. |
/gemini Still reviewing? |
It appears I am still reviewing the pull request. I will provide feedback as soon as possible. |
This should be in a good state. I'll address any further comments in a follow-up PR. |
go/cf3-callable-streaming-clients-ios
Android PR: firebase/firebase-android-sdk#6602
Contribution Workflow
git remote add upstream https://github.com/firebase/firebase-ios-sdk.git
git fetch upstream && git checkout -b <feature-branch> upstream/streamable-functions
<feature-branch>
is the name of the branch (e.g., add-tests-streamable).git add . && git commit -m "..."
git push origin <feature-branch>
firebase:streamable-functions