Fix RCNConfigRealtime crash. #14518
Merged
Fix RCNConfigRealtime crash. #14518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#Conflicts: # FirebaseRemoteConfig/CHANGELOG.md
ncooke3
reviewed
Mar 3, 2025
ncooke3
approved these changes
Mar 3, 2025
Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
paulb777
reviewed
Mar 6, 2025
#Conflicts: # FirebaseRemoteConfig/CHANGELOG.md
paulb777
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashlytics reports intermittent crashes in -[RCNConfigRealtime URLSession:dataTask:didReceiveData:] due to substring construction errors. The code assumes { and } delimiters within NSData from NSURLSession will always occur in order, leading to failures when this assumption is violated.
Error: RCNConfigRealtime crash "CFString cannot be created from a negative number of bytes"
Discussion Link: #14094
As a quick fix to avoid crashes, we will search for endRange.location from the index after beginRange.location, so that we can process the next valid JSON, even when chunk splits are improper.
As a long term fix, we are planning to include buffering logic, where we buffer the data until we receive complete JSON.