Add DataConnect product definition to build.sh #14527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build script is reused by DataConnect which needs a min deployment target of 15.0. Without this, some integration tests are failing due to version check.
ncooke3
approved these changes
Mar 4, 2025
It occurs in our generated code within Integration tests. We were not running integration tests in Git. I used to run them manually within my IDE. It showed up when I started executing them within git which has a lower platform target. |
|
makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build script is reused by DataConnect which needs a min deployment target of 15.0. Without this, some integration tests are failing due to version check.
FYI -
Workflow definition where the build script is invoked
https://github.com/firebase/data-connect-ios-sdk/blob/main/.github/workflows/spm.yml#L77
Error ->
https://github.com/firebase/data-connect-ios-sdk/actions/runs/13660926083/job/38191785059?pr=43#step:7:1814