Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Update generate_issues.yml to give GITHUB_TOKEN write permissions for issues. #14529

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Mar 5, 2025

I'll handle check failure in subsequent PR.

#no-changelog

… issues.

The  workflow file was updated to include the  block to give the  write permissions to create issues. This change was made by adding  to the workflow. Tests could not be run to confirm that the change did not introduce any regressions, but the change was very small and was manually inspected.
@ncooke3 ncooke3 requested a review from andrewheard March 5, 2025 15:04
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ncooke3! Looks like clang-format needs to be upgraded to clang-format@20 now (I think that's the fix you meant in a subsequent PR, which SGTM).

@ncooke3 ncooke3 merged commit f2d1b72 into main Mar 5, 2025
25 of 26 checks passed
@ncooke3 ncooke3 deleted the github-token-issue-permissions branch March 5, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants