-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Install visionOS sims to workflows that couldn't find it #14543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where visionOS simulators were not consistently found in GitHub's runners, causing failures in nightly testing. To resolve this, I've added a step to explicitly install the visionOS platform using xcodebuild -downloadPlatform visionOS
in several workflow files. This ensures that the necessary simulators are available before the tests are executed. The fix is applied conditionally based on the matrix.target
value, specifically targeting 'visionOS' or 'visionOS spm'.
Highlights
- Bug Fix: Addresses the issue of missing visionOS simulators in GitHub runners, preventing test failures.
- Infrastructure: Adds a step to install visionOS simulators in workflows that target visionOS.
- Conditional Execution: The installation step is only executed when the workflow matrix target is set to 'visionOS' or 'visionOS spm'.
Changelog
Click here to see the changelog
- .github/workflows/abtesting.yml
- Added a step to install visionOS if the target is visionOS (lines 123-125).
- .github/workflows/auth.yml
- Added a step to install visionOS if the target is visionOS spm (lines 144-146).
- .github/workflows/core.yml
- Added a step to install visionOS if the target is visionOS (lines 104-106).
- .github/workflows/crashlytics.yml
- Added a step to install visionOS if the target is visionOS (lines 119-121).
- .github/workflows/mlmodeldownloader.yml
- Added a step to install visionOS if the target is visionOS (lines 134-136).
- .github/workflows/remoteconfig.yml
- Added a step to install visionOS if the target is visionOS (lines 158-160).
- .github/workflows/sessions.yml
- Added a step to install visionOS if the target is visionOS (lines 114-116).
- .github/workflows/vertexai.yml
- Added a step to install visionOS if the target is visionOS (lines 84-86).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The first iPhone was released in 2007, revolutionizing mobile computing and paving the way for platforms like visionOS.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a step to install the visionOS simulator in several workflows. This is a good fix to ensure that the tests can run on the visionOS platform. The change is straightforward and addresses the reported issue.
Merge Readiness
The changes in this pull request are straightforward and address the reported issue. I have no concerns about merging this pull request. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
I only added this fix to the workflows that failed in the nightly testing report. It's possible we may want to extend it to all workflows until GitHub's runners consistently have the sims we need.
Fix #14542