Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless method #14544

Merged
merged 1 commit into from
Mar 7, 2025
Merged

remove useless method #14544

merged 1 commit into from
Mar 7, 2025

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Mar 7, 2025

deprecated the use [UIApplication openURL:] and useless method

#no-changelog

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @themiswang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes a deprecated method, FIRCLSApplicationOpenURL, from FIRCLSApplication.h and FIRCLSApplication.m. It also adds some files to CrashlyticsInputFiles.xcfilelist and creates a new run script. The stated reason is to deprecate the use of [UIApplication openURL:] and a useless method, with a stated #no-change.

Highlights

  • Method Removal: The FIRCLSApplicationOpenURL method has been removed from both the header and implementation files.
  • File List Update: The CrashlyticsInputFiles.xcfilelist file has been updated to include several new files related to debug symbols and the GoogleService-Info.plist.
  • New Run Script: A new run script has been added, which is intended to be used as a build phase script for Xcode projects to upload debug symbols and handle Crashlytics onboarding.

Changelog

  • Crashlytics/Crashlytics/Components/FIRCLSApplication.h
    • Removed the FIRCLSApplicationOpenURL function declaration (lines 86-88).
  • Crashlytics/Crashlytics/Components/FIRCLSApplication.m
    • Removed the FIRCLSApplicationOpenURL function implementation (lines 158-182).
  • CrashlyticsInputFiles.xcfilelist
    • Added several files related to debug symbols and GoogleService-Info.plist.
  • run
    • Added a new script to upload debug symbols and handle Crashlytics onboarding.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is the purpose of a dSYM file?

Click here for the answer
dSYM files contain the debug symbols for an application. They are used to symbolicate crash reports, which means converting memory addresses in the crash report to human-readable function names and line numbers.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@themiswang themiswang requested a review from samedson March 7, 2025 15:11
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes a deprecated method FIRCLSApplicationOpenURL and cleans up related code. Overall, the changes seem straightforward and beneficial. Here's a detailed review.

Merge Readiness

The pull request appears to be in good shape for merging. The deprecated method has been removed, and the associated code cleanup seems correct. Since there are no critical or high severity issues, and no style guide violations, I would recommend that this pull request be merged after another team member reviews it. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove run and upload-symbols copies

@themiswang themiswang force-pushed the cleanUIApplicationOpenURL branch 2 times, most recently from 206a30f to a9cd2d8 Compare March 7, 2025 16:49
@themiswang themiswang force-pushed the cleanUIApplicationOpenURL branch from a9cd2d8 to 5ffd533 Compare March 7, 2025 16:53
@themiswang themiswang enabled auto-merge (squash) March 7, 2025 16:54
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@themiswang themiswang merged commit c0501cb into main Mar 7, 2025
24 checks passed
@themiswang themiswang deleted the cleanUIApplicationOpenURL branch March 7, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants