Remove VertexAI sample #14553
Remove VertexAI sample #14553
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @paulb777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request removes the VertexAI sample from the current repository, as it has been migrated to the quickstart-ios repository. This involves deleting the sample code and removing the associated workflow configurations.
Highlights
- Sample Removal: The primary change is the complete removal of the VertexAI sample, including its source code, assets, and related configurations.
- Workflow Update: The
vertexai.ymlworkflow file is modified to remove the 'sample' job, which was responsible for building and testing the VertexAI sample.
Changelog
Click here to see the changelog
- .github/workflows/vertexai.yml
- Removed the 'sample' job, which built and tested the VertexAI sample application.
- The spm-package-resolved job is still present, as is the build and test job.
- FirebaseVertexAI/Sample/ChatSample/Assets.xcassets/AccentColor.colorset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Assets.xcassets/AppIcon.appiconset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Models/ChatMessage.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Preview Content/Preview Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Screens/ConversationScreen.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/ViewModels/ConversationViewModel.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Views/BouncingDots.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Views/ErrorDetailsView.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Views/ErrorView.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ChatSample/Views/MessageView.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/FunctionCallingSample/Screens/FunctionCallingScreen.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/FunctionCallingSample/ViewModels/FunctionCallingViewModel.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIMultimodalSample/Assets.xcassets/AccentColor.colorset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIMultimodalSample/Assets.xcassets/AppIcon.appiconset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIMultimodalSample/Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIMultimodalSample/Preview Content/Preview Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIMultimodalSample/Screens/PhotoReasoningScreen.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIMultimodalSample/ViewModels/PhotoReasoningViewModel.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAITextSample/Assets.xcassets/AccentColor.colorset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAITextSample/Assets.xcassets/AppIcon.appiconset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAITextSample/Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAITextSample/Preview Content/Preview Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAITextSample/Screens/SummarizeScreen.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAITextSample/ViewModels/SummarizeViewModel.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIUIComponents/Package.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIUIComponents/Sources/GenerativeAIUIComponents/InputField.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GenerativeAIUIComponents/Sources/GenerativeAIUIComponents/MultimodalInputField.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/GoogleService-Info.plist
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ImagenScreen/ImagenScreen.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/ImagenScreen/ImagenViewModel.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/README.md
- Updated the README to point to the new quickstart location.
- FirebaseVertexAI/Sample/VertexAISample.xcodeproj/project.pbxproj
- Removed references to the VertexAI sample from the project file.
- FirebaseVertexAI/Sample/VertexAISample/Assets.xcassets/AccentColor.colorset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/VertexAISample/Assets.xcassets/AppIcon.appiconset/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/VertexAISample/Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/VertexAISample/ContentView.swift
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/VertexAISample/Preview Content/Preview Assets.xcassets/Contents.json
- Deleted the file, which was part of the VertexAI sample.
- FirebaseVertexAI/Sample/VertexAISample/VertexAISampleApp.swift
- Deleted the file, which was part of the VertexAI sample.
- scripts/build.sh
- Removed the VertexSample build target.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What year was the first version of the Swift programming language released?
Click here for the answer
The first version of the Swift programming language was released in 2014.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the VertexAI sample from the repository, as it has been moved to the quickstart-ios repo. The changes include removing the sample job from the workflow, deleting the sample code, and updating the README.
Merge Readiness
The pull request removes the VertexAI sample, which is now located in the quickstart-ios repository. The changes seem straightforward and the removal of the sample code and workflow configurations appears correct. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
The sample is now in the quickstart-ios repo (after firebase/quickstart-ios#1675)