[Swift 6] Add Swift 6 testing for CoreInternal #14561
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds Swift 6 testing to the CoreInternal workflow. It modifies the .github/workflows/core_internal.yml file to include a new build environment configuration for Swift 6, using macOS 15 and Xcode 16.2. It also adds a step to set the Swift version in the FirebaseCoreInternal.podspec file based on the matrix environment variable.
Highlights
- Swift 6 Testing: Adds a new job configuration to test CoreInternal with Swift 6.
- Workflow Modification: Updates the
core_internal.ymlworkflow to include Swift 6 testing environment. - Swift Version Setting: Introduces a step to dynamically set the Swift version in the podspec file.
Changelog
- .github/workflows/core_internal.yml
- Added a new build environment to the matrix for macOS 15, Xcode 16.2, and Swift 6.
- Added a step to set the Swift version in
FirebaseCoreInternal.podspecusingsed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the current version of Swift as of June 2024?
Click here for the answer
The current version of Swift is 5.10, released with Xcode 15.4.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds Swift 6 testing for CoreInternal. The changes include updates to the core_internal.yml workflow file to include Swift 6 as a testing environment. The addition of Swift 6 testing is a good step towards ensuring compatibility and stability of the Firebase CoreInternal library.
Summary of Findings
- Swift version setting in podspec: The
swift_versionin theFirebaseCoreInternal.podspecfile is being updated usingsed. While this works, it might be more robust to directly modify theswift_versionwithin the Ruby code of the podspec file. This would avoid potential issues withsedsyntax or unexpected behavior across different environments. - Redundant swift_version assignments: The
swift_versionis assigned to5.9twice in the workflow file. This could be simplified by assigning it once and reusing the value.
Merge Readiness
The pull request introduces Swift 6 testing for CoreInternal, which is a positive step. However, the method of updating the swift_version in the podspec file could be improved for robustness. I recommend addressing the swift_version setting in podspec before merging. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
#no-changelog