[vertex-ai] App Version for AI Monitoring #14568
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
| if firebaseInfo.app.isDataCollectionDefaultEnabled { | ||
| urlRequest.setValue(firebaseInfo.googleAppID, forHTTPHeaderField: "X-Firebase-AppId") | ||
| let appVersion = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? | ||
| "unknown" |
There was a problem hiding this comment.
We need to agree on an empty/unknown treatment across all platforms. I would prefer leaving the header unset if the value can't be reliably determined. This way there's only one empty case.
Add the app version to the request for AI Monitoring. (Also re-enable the google-app-id)
Merging is pending PDD approval
#no-changelog