Skip to content

Commit c6a8851

Browse files
authored
Run Storage Node tests in CI (#8375)
The script that runs the tests in CI accepts a `-s` flag we use to pass the test command we want to run in CI. We were passing two commands, and only the first one (`test:browser`) was being run, skipping the Node tests. Now we only pass one command `test`, which runs both.
1 parent 4c2c78b commit c6a8851

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/storage/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@
3434
"build:deps": "lerna run --scope @firebase/storage --include-dependencies build",
3535
"dev": "rollup -c -w",
3636
"test": "run-p --npm-path npm test:browser test:node lint",
37-
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser test:node",
37+
"test:all": "run-p --npm-path npm test:browser test:node",
38+
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
3839
"test:browser:unit": "karma start --single-run --unit",
3940
"test:browser:integration": "karma start --single-run --integration",
4041
"test:browser": "karma start --single-run",

0 commit comments

Comments
 (0)