Skip to content

Fix encoding of CSI keys in Safari #8993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 9, 2025
Merged

Conversation

MarkDuckworth
Copy link
Contributor

@MarkDuckworth MarkDuckworth commented May 2, 2025

  • Fixes karma timeout in Firestore tests (consistent in WebKit, intermittent in other browsers)
  • Works around bug in Safari/WebKit encoding of keys that are use for client side indexing. This issue was discovered after the timeout was resolved.

Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 0dc1ea6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@firebase/firestore Patch
@firebase/util Minor
firebase Patch
@firebase/firestore-compat Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/data-connect Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/database Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/storage Patch
@firebase/vertexai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 2, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.1

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 2, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (f8334ea)Merge (0458354)Diff
    browser385 kB385 kB+596 B (+0.2%)
    main595 kB596 kB+1.31 kB (+0.2%)
    module385 kB385 kB+596 B (+0.2%)
    react-native385 kB385 kB+600 B (+0.2%)
  • @firebase/util

    TypeBase (f8334ea)Merge (0458354)Diff
    browser23.5 kB23.7 kB+207 B (+0.9%)
    main29.7 kB30.0 kB+301 B (+1.0%)
    module23.5 kB23.7 kB+207 B (+0.9%)
  • @firebase/vertexai

    TypeBase (f8334ea)Merge (0458354)Diff
    browser34.7 kB36.0 kB+1.26 kB (+3.6%)
    main35.7 kB37.0 kB+1.28 kB (+3.6%)
    module34.7 kB36.0 kB+1.26 kB (+3.6%)
  • bundle

    TypeBase (f8334ea)Merge (0458354)Diff
    firestore (CSI Auto Indexing Disable and Delete)275 kB275 kB+407 B (+0.1%)
    firestore (CSI Auto Indexing Enable)275 kB275 kB+407 B (+0.1%)
    firestore (Persistence)306 kB307 kB+407 B (+0.1%)
    firestore (Read Write w Persistence)331 kB331 kB+407 B (+0.1%)
  • firebase

    TypeBase (f8334ea)Merge (0458354)Diff
    firebase-compat.js797 kB798 kB+379 B (+0.0%)
    firebase-firestore-compat.js342 kB343 kB+388 B (+0.1%)
    firebase-firestore.js443 kB444 kB+767 B (+0.2%)
    firebase-vertexai.js28.3 kB29.3 kB+1.03 kB (+3.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TCYNakPczS.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 2, 2025

Size Analysis Report 1

This report is too large (306,064 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8uQUMLr7zg.html

@MarkDuckworth MarkDuckworth marked this pull request as ready for review May 8, 2025 19:48
@MarkDuckworth MarkDuckworth requested review from a team as code owners May 8, 2025 19:48
@MarkDuckworth MarkDuckworth changed the title Enable only unicode / utf8 string tests Fix encoding of CSI keys in Safari May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

Changeset File Check ⚠️

  • Package @firebase/util has a minor bump which requires an additional line to bump the main "firebase" package to minor.

Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this issue. Looks good. A few nits pointed out below.

@MarkDuckworth MarkDuckworth merged commit 8a03143 into main May 9, 2025
47 of 49 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/timeout-flake branch May 9, 2025 20:45
@google-oss-bot google-oss-bot mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants