Skip to content

Remove deprecated Auth calls about SignInResult #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 6, 2024
Merged

Remove deprecated Auth calls about SignInResult #1002

merged 7 commits into from
May 6, 2024

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Apr 25, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Remove the Auth calls involving SignInResult in preparation of the next major release, as they have been deprecated for a year now.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/8975915108

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from jonsimantov May 2, 2024 17:27
@a-maurice a-maurice merged commit d457936 into main May 6, 2024
3 checks passed
@a-maurice a-maurice deleted the am-auth_cleanup branch May 6, 2024 23:50
@firebase firebase locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov