Skip to content

Fix iOS simulator tests not initializing the device correctly #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2024
Merged

Fix iOS simulator tests not initializing the device correctly #1039

merged 4 commits into from
Jun 1, 2024

Conversation

a-maurice
Copy link
Collaborator

Description

Provide details of the change, and generalize the change in the PR title above.

Make sure it is using the correct xcode version, and reading the full line to get the device id.

Testing

Describe how you've tested these changes.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice enabled auto-merge (squash) June 1, 2024 00:57
@a-maurice a-maurice disabled auto-merge June 1, 2024 00:58
@a-maurice a-maurice merged commit 9c928b8 into main Jun 1, 2024
4 checks passed
@a-maurice a-maurice deleted the am-ios_simulators branch June 1, 2024 00:58
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a-maurice