More dual space fixes

Author: pbrubeck

firedrake/assemble.py

@@ -1199,10 +1199,10 @@ def allocate(self):
         rank = len(self._form.arguments())
         if rank == 1:
             test, = self._form.arguments()
-            return firedrake.Cofunction(test.function_space().dual())
+            return firedrake.Function(test.function_space().dual())
         elif rank == 2 and self._diagonal:
             test, _ = self._form.arguments()
-            return firedrake.Cofunction(test.function_space().dual())
+            return firedrake.Function(test.function_space().dual())
         else:
             raise RuntimeError(f"Not expected: found rank = {rank} and diagonal = {self._diagonal}")
 

firedrake/slate/slate.py

@@ -60,7 +60,7 @@ class RemoveNegativeRestrictions(MultiFunction):
     """UFL MultiFunction which removes any negative restrictions
     in a form.
     """
-    expr = MultiFunction.reuse_if_untouched
+    ufl_type = MultiFunction.reuse_if_untouched
 
     def negative_restricted(self, o):
         return Zero(o.ufl_shape, o.ufl_free_indices, o.ufl_index_dimensions)

firedrake/ufl_expr.py

@@ -142,7 +142,7 @@ def reconstruct(self, function_space=None,
             raise TypeError(f"Expecting an int, not {number}")
         if function_space.value_shape != self.function_space().value_shape:
             raise ValueError("Cannot reconstruct an Coargument with a different value shape.")
-        return Coargument(function_space, number, part=part)
+        return Argument(function_space, number, part=part)
 
     def equals(self, other):
         if type(other) is not Coargument: