Rckirby/timedep rb #4339
Open
Rckirby/timedep rb #4339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
reviewed
May 29, 2025
demos/time_dependent_rayleigh_benard/timedep-rayleigh-benard.py.rst
Outdated
Show resolved
Hide resolved
demos/time_dependent_rayleigh_benard/timedep-rayleigh-benard.py.rst
Outdated
Show resolved
Hide resolved
demos/time_dependent_rayleigh_benard/timedep-rayleigh-benard.py.rst
Outdated
Show resolved
Hide resolved
pbrubeck
reviewed
May 29, 2025
demos/time_dependent_rayleigh_benard/timedep-rayleigh-benard.py.rst
Outdated
Show resolved
Hide resolved
pbrubeck
reviewed
May 29, 2025
| mh = MeshHierarchy(base_msh, ref_levels) | ||
| msh = mh[-1] | ||
|
|
||
| MC = MeshConstant(msh) |
There was a problem hiding this comment.
This needs a little bit of explanation. I think the only reason to use the R space is to be able to take the adjoint of a simulation for variables that appear inside a Form and are updated at each time step. This example might be fine with just Constant.
There was a problem hiding this comment.
I thought we had UFL manipulation errors internally with Constant?
Also, t += dt works great for MC but not for `Constant.
There was a problem hiding this comment.
I'll try this out and see if it passes CI. Worked locally for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a demo solving the time-dependent Rayleigh-Benard convection problem using Irksome for time stepping and a monolithic multigrid solver for the algebraic systems.