Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Boolean values do not work in .post and .patch #12

Open
anthonyscorrea opened this issue Oct 9, 2021 · 1 comment
Open

Boolean values do not work in .post and .patch #12

anthonyscorrea opened this issue Oct 9, 2021 · 1 comment

Comments

@anthonyscorrea
Copy link

anthonyscorrea commented Oct 9, 2021 •
edited
Loading

I've found that boolean values are not creating. Not sure if this is a server issue, and I haven't yet tested if something changed in KankaClient or GenericChild.

ex.
response = Character(client).post(name="Johnathan Green", is_private=True)

response.json()['is_private'] = false and should be true
@anthonyscorrea anthonyscorrea changed the title Boolean values do not work in .post and .update Boolean values do not work in .post and .patch Oct 10, 2021
@anthonyscorrea
Copy link
Author

anthonyscorrea commented Oct 10, 2021 •
edited
Loading

seems to work in postman and master branch. guessing something changed in GenericChild.

anthonyscorrea added a commit to anthonyscorrea/pykanka that referenced this issue Oct 10, 2021
@anthonyscorrea
in request, changed "data" kwarg to "json"
3621b25 
JSON body request fixes issue firelilith#12 while retaining compatability.
@anthonyscorrea anthonyscorrea mentioned this issue Oct 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonyscorrea