Feature/dashboard introduction #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-stasiak
requested changes
Sep 8, 2023
| There are plenty of settings that You can adjust in a room: | ||
|  | ||
|
|
||
| - **vp8 or h264** - video codec used in the room. If you want to use `HLS` streaming, you need to use `h264`. |
There was a problem hiding this comment.
- You could also mention that you need a h264 to stream RTSP to WebRTC
- on the screenshot h264 is the first value, so maybe change to
h264 or vp8🫨
Comment on lines
+98
to
+99
| You can also register your callbacks in your Jellyfish projects. | ||
|  |
There was a problem hiding this comment.
Needs additional space
Suggested change
| You can also register your callbacks in your Jellyfish projects. | |
|  | |
| You can also register your callbacks in your Jellyfish projects. | |
|  |
|
|
||
| Jellyfish Server supports loadbalancing. It means that you can run multiple instances of the server and use them simultanoesly to minimise the load on each of them. | ||
| The dashboard reflects this feature. Provided you run multiple-in-one Jellyfish instance (docker does that by default), | ||
| connect one server to the dashboard. When the room you created was moved to another server, the dashboard will open this server for you. |
There was a problem hiding this comment.
When the room you created was moved to another server, the dashboard will open this server for you
That could be misleading. The room was not moved, but it was created on another server
| ## Loadbalancing in Dashboard | ||
|
|
||
| Jellyfish Server supports loadbalancing. It means that you can run multiple instances of the server and use them simultanoesly to minimise the load on each of them. | ||
| The dashboard reflects this feature. Provided you run multiple-in-one Jellyfish instance (docker does that by default), |
There was a problem hiding this comment.
Suggested change
| The dashboard reflects this feature. Provided you run multiple-in-one Jellyfish instance (docker does that by default), | |
| The dashboard reflects this feature. Provided you run multiple-in-one Jellyfish instance (docker compose does that by default), |
| - **WS/WSS** - whether to use a secure or insecure connection. , it's `ws`, but if the backend uses secure WebSocket, use `wss`. | ||
| - **HTTP/HTTPS** - whether to use a secure or insecure connection. By default, it's `http`, but if the backend uses secure HTTP, use `https`. | ||
| - **Server URL** - URL of the backend server. Here, `localhost:5002` would be a local build, but it can be any URL that points to the backend. | ||
| - **Socket Path** - path to the WebSocket endpoint. The default value is `/socket/peer/websocket`. |
There was a problem hiding this comment.
Suggested change
| - **Socket Path** - path to the WebSocket endpoint. The default value is `/socket/peer/websocket`. | |
| - **Socket Path** - path to the signalling WebSocket endpoint. The default value is `/socket/peer/websocket`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.