Set stop function optional

Author: kamil-stasiak

src/components/AudioDevicePanel.tsx

@@ -7,7 +7,7 @@ import { TrackSource } from "../containers/Client";
 type AudioDevicePanelProps = {
   deviceId: string;
   label: string;
-  addLocalAudioStream: (stream: MediaStream, id: string, source: TrackSource, stop: () => void) => void;
+  addLocalAudioStream: (stream: MediaStream, id: string, source: TrackSource, stop?: () => void) => void;
   setSelectedAudioId: (cameraId: DeviceInfo | null) => void;
   selected: boolean;
 };
@@ -24,7 +24,7 @@ export const AudioDevicePanel = ({
         const id = deviceId + uuidv4();
         getUserMedia(id, "audio").then((stream) => {
           setSelectedAudioId({ id: id, type: "audio", stream: stream });
-          addLocalAudioStream(stream, id, "navigator", () => {});
+          addLocalAudioStream(stream, id, "navigator");
         });
       }}
     >

src/components/MockVideoPanel.tsx

@@ -12,7 +12,7 @@ import { TrackSource } from "../containers/Client";
 
 type MockVideoPanelProps = {
   id: string;
-  addLocalVideoStream: (stream: MediaStream, id: string, source: TrackSource, stop: () => void) => void;
+  addLocalVideoStream: (stream: MediaStream, id: string, source: TrackSource, stop?: () => void) => void;
   selectedDeviceId: DeviceInfo | null;
   setSelectedDeviceId: (info: DeviceInfo | null) => void;
 };

src/components/ScreensharingPanel.tsx

@@ -6,7 +6,7 @@ import { v4 as uuidv4 } from "uuid";
 import { TrackSource } from "../containers/Client";
 
 type ScreensharingPanelProps = {
-  addLocalStream: (stream: MediaStream, id: string, source: TrackSource, stop: () => void) => void;
+  addLocalStream: (stream: MediaStream, id: string, source: TrackSource, stop?: () => void) => void;
   label: string;
   setSelectedDeviceId: (trackId: DeviceInfo | null) => void;
 };
@@ -36,9 +36,9 @@ export const ScreensharingPanel = ({ label, addLocalStream, setSelectedDeviceId
                 const videoStream = new MediaStream(stream.getVideoTracks());
                 const audioStream = new MediaStream(stream.getAudioTracks());
                 setSelectedDeviceId({ id: videoId, type: "screenshare", stream: videoStream });
-                addLocalStream(videoStream, videoId, "navigator", () => {});
+                addLocalStream(videoStream, videoId, "navigator");
                 if (screenshareAudio) {
-                  addLocalStream(audioStream, audioId, "navigator", () => {});
+                  addLocalStream(audioStream, audioId, "navigator");
                 }
               });
           } else {

src/components/StreamingDeviceSelector.tsx

@@ -21,7 +21,7 @@ type StreamingDeviceSelectorProps = {
   id: string;
   selectedDeviceId: DeviceInfo | null;
   setSelectedDeviceId: (info: DeviceInfo | null) => void;
-  addLocalStream: (stream: MediaStream, id: string, source: TrackSource, stop: () => void) => void;
+  addLocalStream: (stream: MediaStream, id: string, source: TrackSource, stop?: () => void) => void;
 };
 
 const widthAtom = atomWithStorage("width-constraint", 1280);

src/components/VideoDevicePanel.tsx

@@ -8,7 +8,7 @@ import { showToastInfo } from "./Toasts";
 type VideoDevicePanelProps = {
   deviceId: string;
   label: string;
-  addLocalVideoStream: (stream: MediaStream, id: string, source: TrackSource, stop: () => void) => void;
+  addLocalVideoStream: (stream: MediaStream, id: string, source: TrackSource, stop?: () => void) => void;
   setSelectedVideoId: (cameraId: DeviceInfo | null) => void;
   selected: boolean;
   constraints?: MediaTrackConstraints;
@@ -49,7 +49,7 @@ export const VideoDevicePanel = ({
             })
             .then((stream) => {
               setSelectedVideoId({ id: id, type: "video", stream });
-              addLocalVideoStream(stream, id, "navigator", () => {});
+              addLocalVideoStream(stream, id, "navigator");
             })
             .catch(() => {
               setActiveLocalCameras((prev) => prev - 1);

src/containers/Client.tsx

@@ -118,7 +118,7 @@ export const Client = ({ roomId, peerId, token, id, refetchIfNeeded, remove, rem
     }
   };
 
-  const addLocalStream = (stream: MediaStream, id: string, source: "mock" | "navigator", stop: () => void) => {
+  const addLocalStream = (stream: MediaStream, id: string, source: "mock" | "navigator", stop?: () => void) => {
     stream.getVideoTracks().forEach((track) => {
       if (id.includes("screenshare")) {
         dispatch({

src/containers/StreamingSettingsCard.tsx

@@ -22,7 +22,7 @@ type StreamingSettingsCardProps = {
   setMaxBandwidth: (value: string | null) => void;
   attachMetadata: boolean;
   setAttachMetadata: (value: boolean) => void;
-  addLocalStream: (stream: MediaStream, id: string, source: TrackSource, stop: () => void) => void;
+  addLocalStream: (stream: MediaStream, id: string, source: TrackSource, stop?: () => void) => void;
   currentEncodings: TrackEncoding[];
   setCurrentEncodings: (value: TrackEncoding[]) => void;
   addAudioTrack: (trackInfo: DeviceInfo) => void;