Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

Latest commit

 

History

History
79 lines (50 loc) · 2.65 KB

CONTRIBUTING.md

File metadata and controls

79 lines (50 loc) · 2.65 KB

Contributing

Contributions are always welcome, no matter how large or small!

We want this community to be friendly and respectful to each other. Please follow it in all your interactions with the project. Before contributing, please read the code of conduct.

Development workflow

To get started with the project, run npm install in the root directory to install the required dependencies for each package:

npm install

Make sure your code passes TypeScript and ESLint. Run the following to verify:

npm run watch
npm run lint

To fix formatting errors, run the following:

npm run lint --fix

To use prettier, run the following:

npm run format

Linting

ESLint, Prettier, TypeScript

We use TypeScript for type checking, ESLint with Prettier for linting and formatting the code,

e2e tests

We use Playwright to run e2e tests.

Use the npm run e2e command to run them. You may need to install the browsers using this command: npx playwright install --with-deps.

The e2e tests start a Fishjam instance via Docker and Testcontainers.

Colima

If you are using colima, you need to run these commands first:

export DOCKER_HOST=unix://${HOME}/.colima/default/docker.sock
export TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE=/var/run/docker.sock

See the Testcontainers' documentation to learn about known issues.

Scripts

The package.json file contains various scripts for common tasks:

  • npm run watch: type-check files with TypeScript.
  • npm run lint: lint files with ESLint.
  • npm run format: format files with Prettier.
  • npm run dev: run the dashboard in development mode.
  • npm run build: build the dashboard for production.

Sending a pull request

Working on your first pull request? You can learn how from this free series: How to Contribute to an Open Source Project on GitHub.

When you're sending a pull request:

  • Prefer small pull requests focused on one change.
  • Verify that linters and tests are passing.
  • Review the documentation to make sure it looks good.
  • Follow the pull request template when opening a pull request.
  • For pull requests that change the API or implementation, discuss with maintainers first by opening an issue.