Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

Commit 8d60ecd

Browse files
committed
Fix setting simulcast on iOS
1 parent bcd1705 commit 8d60ecd

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

ios/MembraneWebRTC.swift

+5-3
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,12 @@ class MembraneWebRTC: MembraneRTCDelegate {
157157
initLocalEndpoint()
158158
}
159159

160-
func getVideoParametersFromOptions(connectionOptions: CameraConfig) -> VideoParameters {
160+
func getVideoParametersFromOptions(connectionOptions: CameraConfig) throws -> VideoParameters {
161161
let videoQuality = connectionOptions.quality
162162
let flipVideo = connectionOptions.flipVideo
163163
let videoBandwidthLimit = getMaxBandwidthFromOptions(
164164
maxBandwidth: connectionOptions.maxBandwidth)
165+
let simulcastConfig = try getSimulcastConfigFromOptions(simulcastConfig: connectionOptions.simulcastConfig) ?? SimulcastConfig()
165166

166167
let preset: VideoParameters = {
167168
switch videoQuality {
@@ -192,7 +193,7 @@ class MembraneWebRTC: MembraneRTCDelegate {
192193
let videoParameters = VideoParameters(
193194
dimensions: flipVideo ? preset.dimensions.flip() : preset.dimensions,
194195
maxBandwidth: videoBandwidthLimit,
195-
simulcastConfig: self.videoSimulcastConfig
196+
simulcastConfig: simulcastConfig
196197
)
197198
return videoParameters
198199
}
@@ -284,9 +285,10 @@ class MembraneWebRTC: MembraneRTCDelegate {
284285
try addTrackToLocalEndpoint(cameraTrack, config.videoTrackMetadata.toMetadata(), simulcastConfig)
285286
try setCameraTrackState(cameraTrack: cameraTrack, isEnabled: config.cameraEnabled)
286287
}
288+
287289
private func createCameraTrack(config: CameraConfig) throws -> LocalVideoTrack? {
288290
try ensureConnected()
289-
let videoParameters = getVideoParametersFromOptions(connectionOptions: config)
291+
let videoParameters = try getVideoParametersFromOptions(connectionOptions: config)
290292
guard
291293
let simulcastConfig = try getSimulcastConfigFromOptions(
292294
simulcastConfig: config.simulcastConfig)

0 commit comments

Comments
 (0)