Merge pull request #30 from fjall-rs/perf/no-compression

perf: allow setting compression to None

Author: marvin-j97

src/config.rs

@@ -13,22 +13,22 @@ pub struct Config<BC: BlobCache, C: Compressor + Clone> {
     pub(crate) blob_cache: BC,
 
     /// Compression to use
-    pub(crate) compression: C,
+    pub(crate) compression: Option<C>,
 }
 
 impl<BC: BlobCache, C: Compressor + Clone + Default> Config<BC, C> {
     /// Creates a new configuration builder.
     pub fn new(blob_cache: BC) -> Self {
         Self {
             blob_cache,
-            compression: Default::default(),
+            compression: None,
             segment_size_bytes: 128 * 1_024 * 1_024,
         }
     }
 
     /// Sets the compression & decompression scheme.
     #[must_use]
-    pub fn compression(mut self, compressor: C) -> Self {
+    pub fn compression(mut self, compressor: Option<C>) -> Self {
         self.compression = compressor;
         self
     }

src/segment/multi_writer.rs

@@ -53,9 +53,9 @@ impl<C: Compressor + Clone> MultiWriter<C> {
     /// Sets the compression method
     #[must_use]
     #[doc(hidden)]
-    pub fn use_compression(mut self, compressor: C) -> Self {
-        self.compression = Some(compressor.clone());
-        self.get_active_writer_mut().compression = Some(compressor);
+    pub fn use_compression(mut self, compressor: Option<C>) -> Self {
+        self.compression.clone_from(&compressor);
+        self.get_active_writer_mut().compression = compressor;
         self
     }
 

src/segment/reader.rs

@@ -55,8 +55,8 @@ impl<C: Compressor + Clone> Reader<C> {
         }
     }
 
-    pub(crate) fn use_compression(mut self, compressor: C) -> Self {
-        self.compression = Some(compressor);
+    pub(crate) fn use_compression(mut self, compressor: Option<C>) -> Self {
+        self.compression = compressor;
         self
     }
 }

tests/compression.rs

@@ -23,7 +23,10 @@ fn compression() -> value_log::Result<()> {
 
     let index = MockIndex::default();
 
-    let value_log = ValueLog::open(vl_path, Config::<_, Lz4Compressor>::new(NoCacher))?;
+    let value_log = ValueLog::open(
+        vl_path,
+        Config::<_, Lz4Compressor>::new(NoCacher).compression(Some(Lz4Compressor)),
+    )?;
 
     let mut index_writer = MockIndexWriter(index.clone());
     let mut writer = value_log.get_writer()?;