add more test cases

Author: marvin-j97

src/manifest.rs

@@ -66,7 +66,7 @@ impl<C: Compressor + Clone> SegmentManifest<C> {
         for dirent in std::fs::read_dir(folder)? {
             let dirent = dirent?;
 
-            if dirent.file_type()?.is_dir() {
+            if dirent.file_type()?.is_file() {
                 let segment_id = dirent
                     .file_name()
                     .to_str()
@@ -76,7 +76,7 @@ impl<C: Compressor + Clone> SegmentManifest<C> {
 
                 if !registered_ids.contains(&segment_id) {
                     log::trace!("Deleting unfinished vLog segment {segment_id}");
-                    std::fs::remove_dir_all(dirent.path())?;
+                    std::fs::remove_file(dirent.path())?;
                 }
             }
         }

tests/recovery_delete_unfinished.rs

@@ -0,0 +1,62 @@
+use test_log::test;
+use value_log::{Compressor, Config, IndexWriter, MockIndex, MockIndexWriter, ValueLog};
+
+#[derive(Clone, Default)]
+struct NoCompressor;
+
+impl Compressor for NoCompressor {
+    fn compress(&self, bytes: &[u8]) -> value_log::Result<Vec<u8>> {
+        Ok(bytes.into())
+    }
+
+    fn decompress(&self, bytes: &[u8]) -> value_log::Result<Vec<u8>> {
+        Ok(bytes.into())
+    }
+}
+
+#[test]
+fn recovery_delete_unfinished() -> value_log::Result<()> {
+    let folder = tempfile::tempdir()?;
+    let vl_path = folder.path();
+
+    let index = MockIndex::default();
+
+    let items = ["a", "b", "c", "d", "e"];
+
+    {
+        let value_log = ValueLog::open(vl_path, Config::<NoCompressor>::default())?;
+
+        {
+            let mut index_writer = MockIndexWriter(index.clone());
+            let mut writer = value_log.get_writer()?;
+
+            for key in &items {
+                let value = key.repeat(10_000);
+                let value = value.as_bytes();
+
+                let key = key.as_bytes();
+
+                let vhandle = writer.get_next_value_handle();
+                index_writer.insert_indirect(key, vhandle, value.len() as u32)?;
+
+                writer.write(key, value)?;
+            }
+
+            value_log.register_writer(writer)?;
+        }
+    }
+
+    let faux_segment = vl_path.join("segments").join("5");
+    {
+        std::fs::File::create(&faux_segment)?;
+    }
+
+    {
+        let value_log = ValueLog::open(vl_path, Config::<NoCompressor>::default())?;
+        assert_eq!(1, value_log.segment_count());
+    }
+
+    assert!(!faux_segment.try_exists()?);
+
+    Ok(())
+}

tests/recovery_mac_ds_store.rs

@@ -0,0 +1,59 @@
+use test_log::test;
+use value_log::{Compressor, Config, IndexWriter, MockIndex, MockIndexWriter, ValueLog};
+
+#[derive(Clone, Default)]
+struct NoCompressor;
+
+impl Compressor for NoCompressor {
+    fn compress(&self, bytes: &[u8]) -> value_log::Result<Vec<u8>> {
+        Ok(bytes.into())
+    }
+
+    fn decompress(&self, bytes: &[u8]) -> value_log::Result<Vec<u8>> {
+        Ok(bytes.into())
+    }
+}
+
+#[test]
+fn recovery_mac_ds_store() -> value_log::Result<()> {
+    let folder = tempfile::tempdir()?;
+    let vl_path = folder.path();
+
+    let index = MockIndex::default();
+
+    let items = ["a", "b", "c", "d", "e"];
+
+    {
+        let value_log = ValueLog::open(vl_path, Config::<NoCompressor>::default())?;
+
+        {
+            let mut index_writer = MockIndexWriter(index.clone());
+            let mut writer = value_log.get_writer()?;
+
+            for key in &items {
+                let value = key.repeat(10_000);
+                let value = value.as_bytes();
+
+                let key = key.as_bytes();
+
+                let vhandle = writer.get_next_value_handle();
+                index_writer.insert_indirect(key, vhandle, value.len() as u32)?;
+
+                writer.write(key, value)?;
+            }
+
+            value_log.register_writer(writer)?;
+        }
+    }
+
+    {
+        std::fs::File::create(vl_path.join("segments").join(".DS_Store"))?;
+    }
+
+    {
+        let value_log = ValueLog::open(vl_path, Config::<NoCompressor>::default())?;
+        assert_eq!(1, value_log.segment_count());
+    }
+
+    Ok(())
+}