Skip to content

Draft: AST visitor pattern #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Draft: AST visitor pattern #91

wants to merge 19 commits into from

Conversation

fkleon
Copy link
Owner

@fkleon fkleon commented Feb 13, 2025 •
edited
Loading

Context

Implements the visitor pattern for the Expression AST.

Features and fixes

  • fix: new Parser, missing lex #90
  • feat: Add support for listing variables in an Expression tree. Possible to extract variables from Expression? #73
  • feat: Add new real number evaluator.
  • feat: Add new interval number evaluator.
  • feat: Add new vector evaluator.
  • feat: Require degree of Root function to be Expression (breaking).
  • feat: Stronger typing for algorithmic function handlers.
  • feat: cleanup evaluator tests; and improve test coverage for interval and vector evaluation types.

@fkleon fkleon self-assigned this Feb 13, 2025
@fkleon fkleon force-pushed the feature-ast-visitor branch from 64847fb to b57272e Compare February 13, 2025 10:51
@fkleon fkleon force-pushed the feature-ast-visitor branch from b57272e to 868a98c Compare February 14, 2025 10:23
@fkleon fkleon force-pushed the feature-ast-visitor branch from 868a98c to 3d94410 Compare March 25, 2025 10:32
fkleon added 14 commits April 7, 2025 22:17
@fkleon
fix: algorithmic function: use correct argument order
19a6674
@fkleon
chore: update documentation and examples
366726b
@fkleon
feat: update test code to use RealEvaluator
c7961f3
@fkleon
feat: Interval evaluator for expressions
e4c4f31
@fkleon
fix: interval: evaluation of exp requires exponent to be a natural nu…
dd20a83 
…mber
@fkleon
feat: Vector evaluator for expressions (first cut)
3929468
@fkleon
fix: vector: throw argument error when scalar is in wrong place
28d1414
@fkleon
feat: implement hierarchical AST visitor
442ae35 
This allows to conditionally visit branches; and to switch evaluation context
in the vector evaluator.
@fkleon
fix: default to throwing unimplemented error in expression visitor
a65a2aa
@fkleon
feat: real: composite function support
4b0e732
@fkleon
chore: update CHANGELOG
be0e12f
@fkleon
feat: remove old evaluate code
a3b186a 
Port remaining code/comments to new evaluators.
@fkleon
chore: tests: display test groups in square brackets
d1ad493
@fkleon
feat: remove old evaluate test code
5335a24
@fkleon fkleon force-pushed the feature-ast-visitor branch from 3d94410 to 5335a24 Compare April 7, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fkleon fkleon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new Parser, missing lex
1 participant
@fkleon